-
Notifications
You must be signed in to change notification settings - Fork 183
Bump version to 9.35.0 #3133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 9.35.0 #3133
Conversation
* draft * temp * update ff * update * test * update
* fix: avoid "undefined" before paragraphs content * fix: set "image" as the default alt value instead of "undefined" --------- Co-authored-by: Francois Dursus <fdursus@veson.com>
* Enhance splitParagraph function to allow preservation of implicit paragraphs after split * Fix preserveImplicitParagraph flag in handleEnterOnParagraph to false * Update packages/roosterjs-content-model-plugins/lib/edit/utils/splitParagraph.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Add beforeLogicalRootChanged event handling and related tests * Rename event type from 'beforeLogicalRootChanged' to 'beforeLogicalRootChange' across relevant files * Update packages/roosterjs-content-model-types/lib/event/LogicalRootChangedEvent.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* dsiable isComposing check for Android * add test --------- Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com>
* Allow plugins to store custom state in undo snapshots * Type fixes * Move to using object instead array
* Initial commit * Pending changes exported from your codespace * fix code and tests * Address comments --------- Co-authored-by: wisaulni <wisaulni@microsoft.com> Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com>
* Enhance image loading handling in ImageEditPlugin to support resizing and editing of images not fully loaded * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Use text-bottom instead of bottom for vertical-align to prevent the image to rotate below the text line. Also add some 5px in margin bottom to compensate for the height of the bottom handles.
* Fix 309357 * improve * improve * improve * Update packages/roosterjs-content-model-types/lib/context/ModelToDomOption.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update packages/roosterjs-content-model-types/lib/context/ModelToDomSettings.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix build --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com>
…leted (#3094) * Fix #3087 * Update packages/roosterjs-content-model-plugins/lib/edit/deleteSteps/deleteParagraphStyle.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update packages/roosterjs-content-model-plugins/lib/edit/deleteSteps/deleteParagraphStyle.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update packages/roosterjs-content-model-plugins/lib/edit/deleteSteps/deleteParagraphStyle.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* karma * change
When inserting a list or table in an indented segment, add the indentation to the block.
New parameter processNonVisibleElements has been added to the DomToModelSettings and DomToModelOptions, allowing optional processing of non-visible elements.
* Fix runtime color for dark mode * add test * fix build
The style direction: RTL does move the table to the right, so use justifySelf:flex-end.
When rotating an image, the resize handles direction must be updated according to the rotation angle.
* Support 'HTMLFast' mode when get HTML * fix build and comment
Bumps [tmp](https://github.com/raszi/node-tmp) from 0.2.1 to 0.2.4. - [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md) - [Commits](raszi/node-tmp@v0.2.1...v0.2.4) --- updated-dependencies: - dependency-name: tmp dependency-version: 0.2.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jiuqing Song <jisong@microsoft.com>
* Add logical root plugin and related presets; enhance event handling with capture option * Update packages/roosterjs-content-model-plugins/lib/imageEdit/ImageEditPlugin.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update demo/scripts/controlsV2/sidePane/presets/PresetPane.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…markdown add support for nested style markdowns
#3127) * Fix 377316: Skip undo snapshot when start to edit image * improve * fix comment
* Support different options for empty line mode in mark down * Fix build * fix test * fix test
When the text segment already has link, do not create the link again.
* Graduate option "disableCache" * Improve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the version to 9.35.0 and includes several key technical improvements and bug fixes related to content model handling, cache plugin updates, and markdown processing enhancements.
- Remove optional parameters from cache plugin state, making domIndexer and textMutationObserver required fields
- Add skipUndo property to ContentChangedEvent interface and update undo handling logic
- Enhance markdown processing with new empty line handling options and improved text formatting
Reviewed Changes
Copilot reviewed 47 out of 48 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| versions.json | Version bump from 9.34.0 to 9.35.0 |
| packages/roosterjs-content-model-types/lib/pluginState/CachePluginState.ts | Make domIndexer and textMutationObserver required fields |
| packages/roosterjs-content-model-types/lib/event/ContentChangedEvent.ts | Add skipUndo property and fix typo in deprecated comment |
| packages/roosterjs-content-model-plugins/lib/edit/handleKeyboardEventCommon.ts | Add function to delete empty block groups |
| packages/roosterjs-content-model-plugins/lib/autoFormat/link/createLink.ts | Fix link processing to return false for existing links |
| packages/roosterjs-content-model-markdown/lib/markdownToModel/appliers/applyTextFormatting.ts | Rewrite text formatting logic with improved marker parsing |
| packages/roosterjs-content-model-core/lib/corePlugin/cache/CachePlugin.ts | Remove cache disabling option and make indexer/observer always available |
| packages/roosterjs-content-model-core/lib/coreApi/formatContentModel/formatContentModel.ts | Add skipUndo logic based on change source |
| demo/scripts/controlsV2/sidePane/editorOptions/OptionsPane.tsx | Remove cache disable option from demo |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...erjs-content-model-markdown/test/markdownToModel/creators/createParagraphFromMarkdownTest.ts
Outdated
Show resolved
Hide resolved
FormatContainer can be used to other elements other than blockquotes. When toggling blockquote in format containers that are not blockquotes, search for the selected elements inside the container and only apply blockquote to theses selected elements.
Bump version to 9.35.0