Skip to content

[Fabric] Add Support for ScrollProvider #14411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 12, 2025
Merged

[Fabric] Add Support for ScrollProvider #14411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a50a97d
Save State
chiaramooney Feb 14, 2025
3331bf2
Continue ScrollProvider Implementation
chiaramooney Feb 24, 2025
5dbc2e7
Complete Implementation
chiaramooney Feb 28, 2025
de7a239
Add Test Infra
chiaramooney Mar 3, 2025
a065822
Change files
chiaramooney Mar 3, 2025
3efa816
Format + Remove Unneeded
chiaramooney Mar 10, 2025
802c976
Add Override
chiaramooney Mar 10, 2025
8f3fdfe
Update Snapshots
chiaramooney Mar 11, 2025
02370c3
Add Comments
chiaramooney Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-7d072016-5414-4327-b40c-a149c1dc34b9.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Add IScrollProvider Implementation",
"packageName": "react-native-windows",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
5 changes: 2 additions & 3 deletions packages/e2e-test-app-fabric/test/ScrollViewComponentTest.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,12 @@ describe('ScrollView Tests', () => {
const dump = await dumpVisualTree('flash_scroll_indicators_button');
expect(dump).toMatchSnapshot();
});
// Disable tests where testID is not found.
/*test('ScrollViews can scroll an item list horizontally', async () => {
test('ScrollViews can scroll an item list horizontally', async () => {
const component = await app.findElementByTestID('scroll_horizontal');
await component.waitForDisplayed({timeout: 20000});
const dump = await dumpVisualTree('scroll_horizontal');
expect(dump).toMatchSnapshot();
});*/
});
test('ScrollView has scrollTo method, scroll to start button', async () => {
const component = await app.findElementByTestID('scroll_to_start_button');
await component.waitForDisplayed({timeout: 20000});
Expand Down
84 changes: 46 additions & 38 deletions packages/e2e-test-app-fabric/test/__snapshots__/AccessibilityTest.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,50 +245,58 @@ exports[`Accessibility Tests Selectable items must have a Selection Container. E
"SelectionPattern.IsSelectionRequired": true,
"__Children": [
{
"AutomationId": "Selectable item 1",
"ControlType": 50000,
"IsKeyboardFocusable": true,
"LocalizedControlType": "button",
"Name": "Selectable item 1",
"AutomationId": "",
"ControlType": 50033,
"LocalizedControlType": "pane",
"Name": "List of selectable items",
"__Children": [
{
"AutomationId": "",
"ControlType": 50020,
"LocalizedControlType": "text",
"Name": "Unselected",
"TextRangePattern.GetText": "Unselected",
"AutomationId": "Selectable item 1",
"ControlType": 50000,
"IsKeyboardFocusable": true,
"LocalizedControlType": "button",
"Name": "Selectable item 1",
"__Children": [
{
"AutomationId": "",
"ControlType": 50020,
"LocalizedControlType": "text",
"Name": "Unselected",
"TextRangePattern.GetText": "Unselected",
},
],
},
],
},
{
"AutomationId": "Selectable item 2",
"ControlType": 50000,
"IsKeyboardFocusable": true,
"LocalizedControlType": "button",
"Name": "Selectable item 2",
"__Children": [
{
"AutomationId": "",
"ControlType": 50020,
"LocalizedControlType": "text",
"Name": "Unselected",
"TextRangePattern.GetText": "Unselected",
"AutomationId": "Selectable item 2",
"ControlType": 50000,
"IsKeyboardFocusable": true,
"LocalizedControlType": "button",
"Name": "Selectable item 2",
"__Children": [
{
"AutomationId": "",
"ControlType": 50020,
"LocalizedControlType": "text",
"Name": "Unselected",
"TextRangePattern.GetText": "Unselected",
},
],
},
],
},
{
"AutomationId": "Selectable item 3",
"ControlType": 50000,
"IsKeyboardFocusable": true,
"LocalizedControlType": "button",
"Name": "Selectable item 3",
"__Children": [
{
"AutomationId": "",
"ControlType": 50020,
"LocalizedControlType": "text",
"Name": "Unselected",
"TextRangePattern.GetText": "Unselected",
"AutomationId": "Selectable item 3",
"ControlType": 50000,
"IsKeyboardFocusable": true,
"LocalizedControlType": "button",
"Name": "Selectable item 3",
"__Children": [
{
"AutomationId": "",
"ControlType": 50020,
"LocalizedControlType": "text",
"Name": "Unselected",
"TextRangePattern.GetText": "Unselected",
},
],
},
],
},
Expand Down
28 changes: 14 additions & 14 deletions packages/e2e-test-app-fabric/test/__snapshots__/FlatListComponentTest.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,8 +479,8 @@ exports[`FlatList Tests A FlatList can be inverted 1`] = `
{
"Automation Tree": {
"AutomationId": "flat_list",
"ControlType": 50014,
"LocalizedControlType": "scroll bar",
"ControlType": 50033,
"LocalizedControlType": "pane",
"__Children": [
{
"AutomationId": "Pizza",
Expand Down Expand Up @@ -1247,8 +1247,8 @@ exports[`FlatList Tests A FlatList can have a content inset 1`] = `
{
"Automation Tree": {
"AutomationId": "flat_list",
"ControlType": 50014,
"LocalizedControlType": "scroll bar",
"ControlType": 50033,
"LocalizedControlType": "pane",
"__Children": [
{
"AutomationId": "Pizza",
Expand Down Expand Up @@ -2015,8 +2015,8 @@ exports[`FlatList Tests A FlatList can have separators 1`] = `
{
"Automation Tree": {
"AutomationId": "flat_list",
"ControlType": 50014,
"LocalizedControlType": "scroll bar",
"ControlType": 50033,
"LocalizedControlType": "pane",
"__Children": [
{
"AutomationId": "Pizza",
Expand Down Expand Up @@ -3243,8 +3243,8 @@ exports[`FlatList Tests A FlatList can have sticky headers 1`] = `
{
"Automation Tree": {
"AutomationId": "flatlist-sticky",
"ControlType": 50014,
"LocalizedControlType": "scroll bar",
"ControlType": 50033,
"LocalizedControlType": "pane",
"__Children": [
{
"AutomationId": "",
Expand Down Expand Up @@ -3906,8 +3906,8 @@ exports[`FlatList Tests A FlatList can nest other Flatlists 1`] = `
{
"Automation Tree": {
"AutomationId": "flatlist-nested",
"ControlType": 50014,
"LocalizedControlType": "scroll bar",
"ControlType": 50033,
"LocalizedControlType": "pane",
"__Children": [
{
"AutomationId": "",
Expand Down Expand Up @@ -4839,8 +4839,8 @@ exports[`FlatList Tests A FlatList has an onEndReached event 1`] = `
{
"Automation Tree": {
"AutomationId": "flat_list",
"ControlType": 50014,
"LocalizedControlType": "scroll bar",
"ControlType": 50033,
"LocalizedControlType": "pane",
"__Children": [
{
"AutomationId": "Pizza",
Expand Down Expand Up @@ -5607,8 +5607,8 @@ exports[`FlatList Tests A FlatList has an onStartReached event 1`] = `
{
"Automation Tree": {
"AutomationId": "flat_list",
"ControlType": 50014,
"LocalizedControlType": "scroll bar",
"ControlType": 50033,
"LocalizedControlType": "pane",
"__Children": [
{
"AutomationId": "Pizza",
Expand Down
Loading