[Fabric] Add Support for ScrollProvider #14411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Area: Accessibility
Area: Fabric
jonthysell
reviewed
Mar 11, 2025
There was a problem hiding this comment.
Is there a reason we need this file now? I don't see any comments in the code as to why it's different from upstream.
There was a problem hiding this comment.
Ah there are some differences. I'll add comments!
jonthysell
approved these changes
Mar 11, 2025
chiaramooney
added a commit
to chiaramooney/react-native-windows
that referenced
this pull request
Mar 13, 2025
* Save State * Continue ScrollProvider Implementation * Complete Implementation * Add Test Infra * Change files * Format + Remove Unneeded * Add Override * Update Snapshots * Add Comments
chiaramooney
added a commit
that referenced
this pull request
Mar 18, 2025
* [Fabric] Add Support for ScrollProvider (#14411) * Save State * Continue ScrollProvider Implementation * Complete Implementation * Add Test Infra * Change files * Format + Remove Unneeded * Add Override * Update Snapshots * Add Comments * Merge * Fix Build * Format + Merge Conflicts * Update Snapshots
chiaramooney
added a commit
to chiaramooney/react-native-windows
that referenced
this pull request
Mar 19, 2025
* Save State * Continue ScrollProvider Implementation * Complete Implementation * Add Test Infra * Change files * Format + Remove Unneeded * Add Override * Update Snapshots * Add Comments
chiaramooney
added a commit
that referenced
this pull request
Mar 21, 2025
…rovider, Role, ScrollProvider (#14436) * [Fabric] Add Support for ITextProvider, ITextProvider2, and ITextRangeProvider (#14332) * Partial Implementation * Add More Implementation * More Implementation * More Implementation * Add Support for Bounding Rectangles * Complete Initial Implementation * Change files * Code Cleanup * Code Cleanup * Update Snapshots + Code Cleanup * Update Snapshots * Address Feedback * Address Feedback * Update Snapshots * Fix Tests --------- Co-authored-by: Jon Thysell <jthysell@microsoft.com> * [Fabric] Add Support for Role Prop (#14352) * Add Support for Role Prop * Change files * Format * Update Tests --------- Co-authored-by: Tatiana Kapos <tatianakapos@microsoft.com> * [Fabric] Add Support for ScrollProvider (#14411) * Save State * Continue ScrollProvider Implementation * Complete Implementation * Add Test Infra * Change files * Format + Remove Unneeded * Add Override * Update Snapshots * Add Comments * Update Change Files * Resolve Merge Conflict * Fix Merge * Update Snapshots --------- Co-authored-by: Jon Thysell <jthysell@microsoft.com> Co-authored-by: Tatiana Kapos <tatianakapos@microsoft.com>
acoates-ms
pushed a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Apr 22, 2025
* Save State * Continue ScrollProvider Implementation * Complete Implementation * Add Test Infra * Change files * Format + Remove Unneeded * Add Override * Update Snapshots * Add Comments
acoates-ms
added a commit
that referenced
this pull request
Apr 24, 2025
…se version (#14606) * [Fabric] Add Support for ScrollProvider (#14411) * Save State * Continue ScrollProvider Implementation * Complete Implementation * Add Test Infra * Change files * Format + Remove Unneeded * Add Override * Update Snapshots * Add Comments * [Fabric] Implement textAlign prop in TextInput (#14407) * Introduce support for textAlign * Add playground textinputs demonstrating textAlign * Oops, let's remove textAlignOnUpdateProps * Change files * Lint fixes * Nit * Make textAlign to be of facebook::react::TextAlignment type * Lint fixes * Don't reinvent the wheel :D * Nit: yarn format * Button Should Pass onAccessibilityTap Prop to Native Code (#14444) * Button should pass onAccessibilityTap to native * Change files * [Fabric] Allow text components to have children (#14438) * get images/views inline with text on fabric * add back in comments * Change files * remove duplicate code * add baseline for textinput * add checks for paper vs fabric * try fixing image * add resize:none and tests * fix override * comment out test * fix tests * fix typo * try to fix tests * comment out text test * mark windows-specific changes * Allow TextInput to scroll (#14448) * Allow TextInput to scroll * Change files * update snapshot * Implement onScrollBeginDrag property for ScrollView for fabric (#14446) Implement onScrollBeginDrag property for ScrollView for fabric (#14446) * [Fabric] Implement letterSpacing for TextInput (#14460) * Implement letterSpacing for TextInput * Change files * Update react-native-windows-9ee8d633-698c-476d-9334-170be2c5dc25.json * Update textinput.tsx * optimize code * Added tooltip property for Text (#14470) * Added tooltip property in Text.windows.js TextProps.windows.js for typescript to recognise it as an attribute of Text component * Added override Text.d.ts to src-win/Libraries/Text/ to add tooltip prop to Text component * Change files * Added Sample/text for tooltip prop tests * Added TextPropsWindows to include windows specific prop tooltip * updated TextProps interface to extednd TextPropsWindows * lint fix for Sample/text.tsx file --------- Co-authored-by: Abhijeet Jha <abhijeetjha@microsoft.com> * [Fabric] Add Custom Font Family in Text Input (#14495) * [Fabric] Fix Bug in Narrator Navigation (#14498) * Fix Narrator Bug * Change files * Revert Codegen Changes * Implemented on onEndEditing for TextInput component (#14489) * implemented on onEndEditing * Change files * Update textinput.tsx to remove keyboard=dismiss which actually will cause blur or lost focus implicitly * lint fixes * updated legacy textInput snapshot for component update --------- Co-authored-by: Abhijeet Jha <abhijeetjha@microsoft.com> * [Fabric] Add ImageRequestParams for Image Component (#14494) * [Fabric] Implement onProgress for Image (#14493) * [Fabric] Implement SpellCheck and AutoCorrect for TextInput (#14509) * Textinput double clicking selects text (#14515) * added check for double click on textInput component view connecting it to WM_LBUTTONDBLCLK * Change files * updated for lint fix * updated to remove position( Distance check) --------- Co-authored-by: Abhijeet Jha <abhijeetjha@microsoft.com> * [Fabric] Implement decelerationRate in ScrollView (#14528) * [Fabric] Implement showsVerticalScrollIndicatorValue and showsHorizontalScrollIndicatorValue for ScrollView (#14526) * SetProperties is not exposed on ReactNativeIsland (#14517) * Add SetAppProperties method to ReactNativeIsland * Change files * rename SetAppProperties to SetProperties * change file * fix * fix * [Fabric] Implement Image body in Image Source RequestImage API (#14568) * Implement body in Image Source * Change files * Add test in playground * [Fabric] Implement zoomScale, maximumZoomScale and minimumZoomScale in ScrollView (#14562) * Implemet maximumZoomScale and minimumZoomScalein ScrollView * Change files * lint fix * Add zoomScale * Implement adjustsFontSizeToFit property for Text in Fabric (#14519) * Implementation of adjustFontSizeToFit * Final Changes using TextLayout * Lint Issue Fixes * Change files * prop change detection added * review Changes and E2E test cases added * Lint and Format Changes added * Test Cases Fix added * Update SnapShot * Removed the additional Check for resizing Font * Updated SnapShot * Review Changes * Lint and Format Changes --------- Co-authored-by: Vineeth K <kvineeth@microsoft.com> * [Fabric] Implement scrollEventThrottle for ScrollView (#14555) * fix build * fixes * fix typo * fixes * fixes * Update WindowsAppSDK version to 1.7.250401001 * fix --------- Co-authored-by: Chiara Mooney <34109996+chiaramooney@users.noreply.github.com> Co-authored-by: Daniel Ayala <14967941+danielayala94@users.noreply.github.com> Co-authored-by: Tatiana Kapos <tatianakapos@microsoft.com> Co-authored-by: Anupriya Verma <54227869+anupriya13@users.noreply.github.com> Co-authored-by: Abhijeet Jha <74712637+iamAbhi-916@users.noreply.github.com> Co-authored-by: Abhijeet Jha <abhijeetjha@microsoft.com> Co-authored-by: Vineeth <66076509+vineethkuttan@users.noreply.github.com> Co-authored-by: Vineeth K <kvineeth@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Why
Accessibility parity with Paper
Resolves #14365
Resolves #14366
Resolves #13356
Resolves #13355
What
Testing
Add Support for dumping IScrollProvider horizontallyScrollable information
Changelog
Should this change be included in the release notes: Yes