Skip to content

fix(apple): fix app autodetection in bridgeless mode #2464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 6, 2025

Conversation

tido64
Copy link
Member

@tido64 tido64 commented May 6, 2025

Description

Fix app autodetection in bridgeless mode.

Requires microsoft/rnx-kit#3604.

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

  1. Remove all components from app.json:
    diff --git a/example/app.json b/example/app.json
    index 3b8992ea..c3f35da3 100644
    --- a/example/app.json
    +++ b/example/app.json
    @@ -3,15 +3,6 @@
       "name": "Example",
       "displayName": "Example",
       "components": [
    -    {
    -      "appKey": "Example",
    -      "displayName": "App"
    -    },
    -    {
    -      "appKey": "Example",
    -      "displayName": "App (modal)",
    -      "presentationStyle": "modal"
    -    }
       ],
       "resources": {
         "android": [
  2. Enable New Arch:
    diff --git a/example/ios/Podfile b/example/ios/Podfile
    index 55a670f4..40a12ab5 100644
    --- a/example/ios/Podfile
    +++ b/example/ios/Podfile
    @@ -7,8 +7,8 @@ require "#{ws_dir}/node_modules/react-native-test-app/test_app.rb"
     workspace 'Example.xcworkspace'
    
     options = {
    -  :fabric_enabled => false,
    -  :hermes_enabled => false,
    +  :fabric_enabled => true,
    +  :hermes_enabled => true,
     }
    
     use_test_app! options do |target|
  3. Build the iOS app
    cd example
    pod install --project-directory=ios
    yarn ios
    
    # In a separate terminal
    yarn start
  4. Verify that the Example app launches

@tido64 tido64 force-pushed the tido/fix-appregistry branch from 1313b0d to b08d8c7 Compare May 6, 2025 13:30
@tido64 tido64 marked this pull request as ready for review May 6, 2025 13:30
@tido64 tido64 requested review from JasonVMo and Saadnajmi as code owners May 6, 2025 13:30
@tido64 tido64 added this to the Single-app Mode milestone May 6, 2025
@tido64 tido64 force-pushed the tido/fix-appregistry branch from 1a6c1f5 to a63bf21 Compare May 6, 2025 15:24
@tido64 tido64 merged commit b094686 into trunk May 6, 2025
30 checks passed
@tido64 tido64 deleted the tido/fix-appregistry branch May 6, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS platform: visionOS platform: Windows This affects Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants