Skip to content

Commit 1a6c1f5

Browse files
committed
.ReactAppDidInitialize -> .ReactAppDidFinishLaunching
1 parent d50dcf7 commit 1a6c1f5

File tree

5 files changed

+15
-9
lines changed

5 files changed

+15
-9
lines changed

example/ios/ExampleTests/DevSupportTests.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ @implementation DevSupportTests
99

1010
- (void)testDevSupportIsLinked
1111
{
12-
XCTAssertNotNil(ReactAppDidInitializeNotification);
12+
XCTAssertNotNil(ReactAppDidFinishLaunchingNotification);
1313
XCTAssertNotNil(ReactAppWillInitializeReactNativeNotification);
1414
XCTAssertNotNil(ReactAppDidInitializeReactNativeNotification);
1515
XCTAssertNotNil(ReactAppSceneDidOpenURLNotification);

ios/ReactTestApp/AppDelegate.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
3838

3939
defer {
4040
NotificationCenter.default.post(
41-
name: .ReactAppDidInitialize,
41+
name: .ReactAppDidFinishLaunching,
4242
object: nil
4343
)
4444
}

ios/ReactTestApp/Public/ReactTestApp-DevSupport.h

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,18 @@
22

33
NS_ASSUME_NONNULL_BEGIN
44

5-
OBJC_EXTERN NSNotificationName const ReactAppDidInitializeNotification;
5+
OBJC_EXTERN NSNotificationName const ReactAppDidFinishLaunchingNotification;
6+
67
OBJC_EXTERN NSNotificationName const ReactAppWillInitializeReactNativeNotification;
78
OBJC_EXTERN NSNotificationName const ReactAppDidInitializeReactNativeNotification;
8-
OBJC_EXTERN NSNotificationName const ReactAppDidRegisterAppsNotification;
9+
910
OBJC_EXTERN NSNotificationName const ReactAppRuntimeReady;
11+
OBJC_EXTERN NSNotificationName const ReactAppDidRegisterAppsNotification;
12+
1013
OBJC_EXTERN NSNotificationName const ReactAppSceneDidOpenURLNotification;
1114

1215
OBJC_EXTERN NSNotificationName const ReactTestAppDidInitializeNotification
13-
__deprecated_msg("Use 'ReactAppDidInitializeNotification' instead");
16+
__deprecated_msg("Use 'ReactAppDidFinishLaunchingNotification' instead");
1417
OBJC_EXTERN NSNotificationName const ReactTestAppWillInitializeReactNativeNotification
1518
__deprecated_msg("Use 'ReactAppWillInitializeReactNativeNotification' instead");
1619
OBJC_EXTERN NSNotificationName const ReactTestAppDidInitializeReactNativeNotification

ios/ReactTestApp/ReactTestApp-DevSupport.m

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,20 @@
11
#import <Foundation/Foundation.h>
22

3-
NSNotificationName const ReactAppDidInitializeNotification = @"ReactAppDidInitializeNotification";
3+
NSNotificationName const ReactAppDidFinishLaunchingNotification = @"ReactAppDidFinishLaunchNotification";
4+
45
NSNotificationName const ReactAppWillInitializeReactNativeNotification =
56
@"ReactAppWillInitializeReactNativeNotification";
67
NSNotificationName const ReactAppDidInitializeReactNativeNotification =
78
@"ReactAppDidInitializeReactNativeNotification";
9+
10+
NSNotificationName const ReactAppRuntimeReady = @"ReactAppRuntimeReady";
811
NSNotificationName const ReactAppDidRegisterAppsNotification =
912
@"ReactAppDidRegisterAppsNotification";
10-
NSNotificationName const ReactAppRuntimeReady = @"ReactAppRuntimeReady";
13+
1114
NSNotificationName const ReactAppSceneDidOpenURLNotification =
1215
@"ReactAppSceneDidOpenURLNotification";
1316

14-
NSNotificationName const ReactTestAppDidInitializeNotification = ReactAppDidInitializeNotification;
17+
NSNotificationName const ReactTestAppDidInitializeNotification = ReactAppDidFinishLaunchingNotification;
1518
NSNotificationName const ReactTestAppWillInitializeReactNativeNotification =
1619
ReactAppWillInitializeReactNativeNotification;
1720
NSNotificationName const ReactTestAppDidInitializeReactNativeNotification =

macos/ReactTestApp/AppDelegate.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
2323

2424
func applicationDidFinishLaunching(_: Notification) {
2525
NotificationCenter.default.post(
26-
name: .ReactAppDidInitialize,
26+
name: .ReactAppDidFinishLaunching,
2727
object: nil
2828
)
2929

0 commit comments

Comments
 (0)