Skip to content

Conversation

@mganandraj
Copy link

@mganandraj mganandraj commented Oct 28, 2020

Rebased relevant patches over RN63 codebase
Removed the dependencies on checked-in version of folly, glog & double-conversion

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Rebased relevant patches over RN63 codebase
Removed the dependencies on checked-in version of folly, glog & double-conversion

Changelog

Rebased relevant patches over RN63 codebase
Removed the dependencies on checked-in version of folly, glog & double-conversion

[CATEGORY] [TYPE] - Message

Test Plan

Office experiences are yet to be tested.

Microsoft Reviewers: Open in CodeFlow

…encies on checked-in version of folly, glog & double-conversion
@pull-bot
Copy link

pull-bot commented Oct 28, 2020

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 19e4cb6

@mganandraj mganandraj marked this pull request as ready for review October 28, 2020 04:40
@mganandraj mganandraj requested a review from alloy as a code owner October 28, 2020 04:40
Copy link
Member

@alloy alloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks! I’ve re-enabled the related CI test and it passes 👍

One question, can we remove the follybuild, glog, and double-conversion directories in the root of the repo too?

@alloy alloy mentioned this pull request Oct 28, 2020
25 tasks
@mganandraj mganandraj merged commit 5c4f68b into microsoft:master Oct 28, 2020
@mganandraj mganandraj deleted the rn63droidpatches branch October 28, 2020 16:54
@alloy
Copy link
Member

alloy commented Oct 29, 2020

@mganandraj Perhaps this question slipped by:

One question, can we remove the follybuild, glog, and double-conversion directories in the root of the repo too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants