Description
openedon Sep 29, 2020
For once #613 is merged.
-
Get Android patches to apply and work as expected and/or move them out of this repo. This includes the Folly, double-conversion, and possible other vendored libs in the root of the repo.Rebasing android patches over RN63 #641 -
Update
react-native-macos-init
:- The Podfile needs reconciliation with with upstream and RNTester
- Ensure the user can enable hermes
-
Go through all
TODO(macOS v0.63)
instances and verify new behaviour -
Ensure the CircleCI nightly job isn't ran
-
RNTester/Podfile
:-
require_relative '../scripts/react_native_pods'
-
use_flipper!
- Change macOS targets to have deployment target of 10.13 (need newer hermes release) depends on [podspec] Build v0.4.x for macOS arm64 facebook/hermes#351. The artefacts need testing on a arm64 DTK.
-
-
Libraries/Components/View/ReactNativeViewViewConfig.js
:
Doplatform === ios
checks need macOS as well? -
Libraries/Pressability/__tests__/Pressability-test.js
:
does this still fail: is called independent of preceding long touch gesture -
facebook@5394c90:Various post-0.63-merge TODOs #631
Should we remove our addition to RCTTextAttributes? -
Various post-0.63-merge TODOs #631Libraries/Text/TextInput/Singleline/RCTUITextField.m
:
Do we still need to disable scrollEnabled on macOS? facebook@827b1fe -
[defork] Remove unnecessary refactor #625React/Base/RCTTouchHandler.m
:
Does- (NSInteger)_eventWithNumber:(NSInteger)touchID
still need to be an extracted method? Was it shared previously? -
Remove outdated version guards #626React/Base/RCTUtils.m
:
DoesRCTForceTouchAvailable
still need a iOS (10) guard? -
Moving this to Enable previously disabled core turbo modules #627React/CoreModules/CoreModulesPlugins.mm
:
Remove guard aroundRCTLogBoxCls
-
Set correct HMR client platform #628React/CxxBridge/RCTCxxBridge.mm
:
Where did this change move? 150f935#diff-a2a67635fffd7b690d14dc17ae563a71R933 -
React/Views/RCTView.m
:
Do we still needsavedTraitCollection
indisplayLayer:
?5bff60f#diff-82cd0f8fb7478261a85ac686ac07be50R793-R8015bff60f#diff-82cd0f8fb7478261a85ac686ac07be50R814-R821
No longer needed, as per @tom-un’s comment below.
-
Revisit the code-sharing between iOS and macOSe030009PlatformColorValueTypes
here 5065f58 -
Is the naming of these alternate color names important? 21c189d
Apparently not v0.63 sync from upstream #613 (comment) -
Image in RNTester doesn't load. The following message is logged:Fixed by Fix RCTImageView not rendering images #637.
Reloading image http://192.168.1.35:8081/assets/node_modules/react-native-macos/Libraries/NewAppScreen/components/logo.png?platform=macos&hash=47ce6e77f039020ee2e76a10c1e988e9 as size {918, nan}
-
LogBox does not have a working full screen version.[LogBox] Add NSWindow based version #645
Not now
-
Should we run clang-format as per upstream? facebook@d0871d0
- Should probably do this last so we can easily merge in master
- Ensure it also runs on cpp files
- Add a git/CI hook to ensure files are prettified?
- Currently upstream
master
is not formatted either, so doesn't seem like the right time. Asking upstream maintainers what their plans are.
-
Libraries/PushNotificationIOS/RCTPushNotificationManager.mm
:
old deprecated macOS ifdef'ed code replaced by: RCTPromiseResolveValueForUNNotificationSettings -
Libraries/PushNotificationIOS/RCTPushNotificationManager.mm
:
use UUUserNotificationCenter on macOS in removeAllDeliveredNotifications, removeDeliveredNotifications, getDeliveredNotifications