Skip to content

v0.63 merge TODOs #621

Closed
Closed

Description

For once #613 is merged.

Not now

  • Should we run clang-format as per upstream? facebook@d0871d0

    • Should probably do this last so we can easily merge in master
    • Ensure it also runs on cpp files
    • Add a git/CI hook to ensure files are prettified?
    • Currently upstream master is not formatted either, so doesn't seem like the right time. Asking upstream maintainers what their plans are.
  • Libraries/PushNotificationIOS/RCTPushNotificationManager.mm:
    old deprecated macOS ifdef'ed code replaced by: RCTPromiseResolveValueForUNNotificationSettings

  • Libraries/PushNotificationIOS/RCTPushNotificationManager.mm:
    use UUUserNotificationCenter on macOS in removeAllDeliveredNotifications, removeDeliveredNotifications, getDeliveredNotifications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions