Various post-0.63-merge TODOs #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alloy
force-pushed
the
post-0.63-merge-todos
branch
2 times, most recently
from
e030009
to
e14757f
Compare
alloy
commented
Oct 8, 2020
| #else // [TODO(macOS ISS#2323203) | ||
| NSInteger startPosition = MIN(start, end); | ||
| NSInteger endPosition = MAX(start, end); | ||
| [self.backedTextInputView setSelectedTextRange:NSMakeRange(startPosition, endPosition - startPosition) notifyDelegate:NO]; |
There was a problem hiding this comment.
There's no bounds checking here, so this would raise a objc exception.
Reverts facebook@5394c90 in favour of seting a default in RCTTextAttributes. This fixes it in one place for both Text and TextInput.
alloy
force-pushed
the
post-0.63-merge-todos
branch
from
bbd37c2
to
c33f895
Compare
|
@tom-un @HeyImChris This is ready for review. For the remaining TODO (LogBox window support) I’ll create a separate PR. |
HeyImChris
approved these changes
Oct 28, 2020
tom-un
requested changes
Oct 28, 2020
ghost
added
tom-un
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #621
Microsoft Reviewers: Open in CodeFlow