[Fabric] Convert UIActivityIndicatorView to RCTActivityIndicatorView shim #1528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
reviewed
Nov 29, 2022
React/Fabric/Mounting/ComponentViews/ActivityIndicator/RCTActivityIndicatorViewComponentView.mm
Outdated
Show resolved
Hide resolved
React/Fabric/Mounting/ComponentViews/ActivityIndicator/RCTActivityIndicatorViewComponentView.mm
Outdated
Show resolved
Hide resolved
added 2 commits
November 30, 2022 13:48
added 3 commits
December 7, 2022 11:43
Saadnajmi
approved these changes
Dec 8, 2022
lyzhan7
approved these changes
Dec 9, 2022
…indicatorview-shim # Conflicts: # React/Base/RCTUIKit.h
Saadnajmi
reviewed
Dec 12, 2022
4 tasks
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
…shim (microsoft#1528) * [Fabric] Replace UIKit with RCTUIKit * [Fabric] Convert UIActivityIndicatorView to RCTActivityIndicatorView shim * Add macOS tags * Shim RCTUIActivityIndicatorView instead of using RCTActivityIndicatorView * Shim correct NSProgressIndicator * Move RCTUIActivityIndicatorView below other defs for easier merges Co-authored-by: Shawn Dempsey <shawndempsey@fb.com> Co-authored-by: lyzhan7 <78454019+lyzhan7@users.noreply.github.com>
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
…shim (microsoft#1528) * [Fabric] Replace UIKit with RCTUIKit * [Fabric] Convert UIActivityIndicatorView to RCTActivityIndicatorView shim * Add macOS tags * Shim RCTUIActivityIndicatorView instead of using RCTActivityIndicatorView * Shim correct NSProgressIndicator * Move RCTUIActivityIndicatorView below other defs for easier merges Co-authored-by: Shawn Dempsey <shawndempsey@fb.com> Co-authored-by: lyzhan7 <78454019+lyzhan7@users.noreply.github.com>
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
…shim (microsoft#1528) * [Fabric] Replace UIKit with RCTUIKit * [Fabric] Convert UIActivityIndicatorView to RCTActivityIndicatorView shim * Add macOS tags * Shim RCTUIActivityIndicatorView instead of using RCTActivityIndicatorView * Shim correct NSProgressIndicator * Move RCTUIActivityIndicatorView below other defs for easier merges Co-authored-by: Shawn Dempsey <shawndempsey@fb.com> Co-authored-by: lyzhan7 <78454019+lyzhan7@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Fabric on macOS implementation:
Replacing references of UIActivityIndicatorView to RCTActivityIndicatorView shim
Changelog
[macOS][Fabric] - Replacing references of UIActivityIndicatorView to RCTActivityIndicatorView shim
Test Plan
[x] Build RNTester-macOS w/ Fabric - doesn’t run yet, but no UIActivityIndicatorView errors
Build errors:
Build RNTester-macOS_2022-11-28T16-13-01.txt
[x] Build RNTester - iOS w/ Fabric - New architecture example should work
https://user-images.githubusercontent.com/96719/204412810-4b41b91c-e9b5-436a-9746-1df4c9707750.mp4
[x] Build RNTester-macOS w/ Paper - should work
[x] Build RNTester - iOS w/ Paper - should work
