[Fabric] Remaining fixes for Fabric building on macOS target #1685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 24, 2023 10:15
shwanton
commented
Jan 24, 2023
Saadnajmi
approved these changes
Jan 24, 2023
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
…ft#1685) * [Fabric] Fix UIKit Shim * [Fabric] Fix RCTUILabel shim * [Fabric] Fix RCTSliderComponent shim * [Fabric] Disable UIApplicationWillTerminateNotification on macOS * [Fabric] Don't check alpha for NSView * [Fabric] Remove duplicate RCTUITouch def * [Fabric] Fix whitespace Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
…ft#1685) * [Fabric] Fix UIKit Shim * [Fabric] Fix RCTUILabel shim * [Fabric] Fix RCTSliderComponent shim * [Fabric] Disable UIApplicationWillTerminateNotification on macOS * [Fabric] Don't check alpha for NSView * [Fabric] Remove duplicate RCTUITouch def * [Fabric] Fix whitespace Co-authored-by: Shawn Dempsey <shawndempsey@fb.com> # Conflicts: # React/Fabric/Mounting/ComponentViews/UnimplementedView/RCTUnimplementedViewComponentView.mm # React/Fabric/RCTSurfacePresenter.mm # Conflicts: # React/Base/macOS/RCTUIKit.m
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
…ft#1685) * [Fabric] Fix UIKit Shim * [Fabric] Fix RCTUILabel shim * [Fabric] Fix RCTSliderComponent shim * [Fabric] Disable UIApplicationWillTerminateNotification on macOS * [Fabric] Don't check alpha for NSView * [Fabric] Remove duplicate RCTUITouch def * [Fabric] Fix whitespace Co-authored-by: Shawn Dempsey <shawndempsey@fb.com> # Conflicts: # React/Fabric/Mounting/ComponentViews/UnimplementedView/RCTUnimplementedViewComponentView.mm # React/Fabric/RCTSurfacePresenter.mm # Conflicts: # React/Base/macOS/RCTUIKit.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Fabric on macOS implementation:
Remaining fixes/shims for Fabric successfully building on macOS target
Closes #1567
Changelog
[macOS][Added] - Remaining fixes for Fabric building on macOS target
Interactions are broken so any input will result in a crash.
Follow on PR will address these issues.
NOTE: To test, this should to be merged after the remaining Fabric PR's
Test Plan
[x] Build RNTester-macOS w/ Fabric - Builds! 🚀
[x] Build RNTester - iOS w/ Fabric
[x] Build RNTester-macOS w/ Paper
[x] Build RNTester - iOS w/ Paper
