Skip to content

Readd test_docker to .circleci/config.yml #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2022

Conversation

amgleitman
Copy link
Member

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

We're seeing some dependabot PR failures (#1167 and #1169) due to a missing job definition, so let's reintroduce that definition to make everyone happy.

@amgleitman amgleitman requested a review from a team as a code owner May 19, 2022 21:38
@Saadnajmi
Copy link
Collaborator

I might be wrong, but I thought someone from @microsoft/rnandroid recently removed this because Android builds were failing from this?

@amgleitman
Copy link
Member Author

amgleitman commented May 21, 2022

I might be wrong, but I thought someone from @microsoft/rnandroid recently removed this because Android builds were failing from this?

Discussed offline, and we decided that this change should be fine.

@amgleitman amgleitman merged commit fbe9c5d into microsoft:main May 21, 2022
@amgleitman amgleitman deleted the readd-test-docker-to-main branch May 21, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants