Skip to content

fix(android-patches): remove ImageColor patch #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2022
Merged

Conversation

kelset
Copy link

@kelset kelset commented May 20, 2022

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

This PR does a quick clean of a patch that is not needed anymore; it was wiped empty during the 0.66 PR (as you can see in this git history) but it was not a problem because the fix was implemented upstream on this commit on 0.66: facebook@842bcb9

Test Plan

Nothing to test - it was an empty file already ;)

@kelset kelset added the Android label May 20, 2022
@kelset kelset requested a review from a team as a code owner May 20, 2022 15:00
@kelset
Copy link
Author

kelset commented May 20, 2022

Looks like CI is failing because of what gets fixed in this PR #1175

@kelset kelset force-pushed the kelset/remove-imagecolor branch from e2ba168 to 3aed7d5 Compare May 24, 2022 10:09
@kelset kelset changed the title remove ImageColor patch fix(android-patches): remove ImageColor patch May 24, 2022
@kelset kelset enabled auto-merge (squash) May 24, 2022 10:47
@kelset kelset merged commit b7b5308 into main May 24, 2022
@kelset kelset deleted the kelset/remove-imagecolor branch May 24, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants