Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Conversation

@jiaminglu
Copy link
Contributor

This pull request fixed:

  1. For newly installed android apps, update check always return new bundle, even if the asset bundle is already the latest, since packageHash is not passed to /updateCheck.
  2. A typo in codepush.gradle

@msftclas
Copy link

@jiaminglu,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas
Copy link

@jiaminglu, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@sergey-akhalkov
Copy link
Contributor

sergey-akhalkov commented May 2, 2017

Hello @jiaminglu, thank you for the contribution. I've just tested your PR and first point (For newly installed android apps...) works like a charm, but second one crashes my test app in release mode. I agree that the def resourcesDirConfigName = "jsBundleDir${targetName}" line looks like a typo, but as of now it crashes the app when we change it.
So I suggest to revert second point for now, because it needs to be investigated more deeply. Please let me know what do you think.

@jiaminglu
Copy link
Contributor Author

jiaminglu commented May 3, 2017

That commit is removed.

The default configuration works well and the problem with resourcesDirConfigName won't cause any problem if we stick to the default configuration.

The problem with this line is that, if we choose to use custom configurations, it might cause the generated resources to be placed in wrong place (together with the .jsbundle file), which resulted in wrong hash calculated. (The generateBundledResourcesHash script decides which file is generated by react-native bundle based on mtime, and thus the .jsbundle file is considered as a resource file)

@sergey-akhalkov
Copy link
Contributor

sergey-akhalkov commented May 4, 2017

@jiaminglu, got it, thanks for the clarification, I'll copy your explanation and create new issue in react-native-code-push repo, just to make sure we won't forgot about it.

@max-mironov
Copy link
Contributor

@jiaminglu thanks for contribution, your PR looks good, merging your PR to Master.

@max-mironov max-mironov merged commit a59e4cf into microsoft:master May 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants