Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.
This repository was archived by the owner on May 20, 2025. It is now read-only.

codepush.gradle: resourcesDirConfigName typo issue #828

@sergey-akhalkov

Description

@sergey-akhalkov

Description

The typo is here, we need to change it to def resourcesDirConfigName = "resourcesDir${targetName}", but as of now it cause an app crash in release mode, so this should be investigated deeply.

The default configuration works well and the problem with resourcesDirConfigName won't cause any problem if we stick to the default configuration.

The problem with this line is that, if we choose to use custom configurations, it might cause the generated resources to be placed in wrong place (together with the .jsbundle file), which resulted in wrong hash calculated. (The generateBundledResourcesHash script decides which file is generated by react-native bundle based on mtime, and thus the .jsbundle file is considered as a resource file)

Relates to #803 (comment)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions