This repository was archived by the owner on Jan 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 174
Use the XML exception tag in doc comments (C#) #732
Merged
github-actions
merged 7 commits into
microsoft:main
from
kevinhartman:keha/except-tag-docs
Nov 24, 2020
Merged
Use the XML exception tag in doc comments (C#) #732
github-actions
merged 7 commits into
microsoft:main
from
kevinhartman:keha/except-tag-docs
Nov 24, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinhartman
commented
Nov 12, 2020
bamarsha
reviewed
Nov 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! It's much easier to see which exceptions a function throws now. :)
A few TODOs prior to merge:
|
50c3111
to
a795141
Compare
b23288c
to
4c39f97
Compare
This one is ready for another look @SamarSha Thanks for all of the great discussion so far! |
bamarsha
reviewed
Nov 21, 2020
85a5fff
to
104349a
Compare
Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com>
104349a
to
1884ee7
Compare
bamarsha
approved these changes
Nov 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks again for working on this!
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds proper XML tags for any exceptions previously mentioned within the summary tag.
Currently, this is only done for C# projects, since most of the F# code uses implicit summary tags.
Ref #699