Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Commit 104349a

Browse files
Address review comments.
Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com>
1 parent 4c39f97 commit 104349a

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/QsCompiler/CompilationManager/DataStructures.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -480,7 +480,7 @@ private HeaderEntry(
480480
/// verifies that it corresponds instead to an invalid symbol and returns null unless the keepInvalid parameter has been set to a string value.
481481
/// If the keepInvalid parameter has been set to a (non-null) string, uses that string as the SymbolName for the returned HeaderEntry instance.
482482
/// </summary>
483-
/// <exception cref="ArgumentException">The symbol of the extracted declaration is not an unqualified symbol and does not instead correspond to an invalid symbol.</exception>
483+
/// <exception cref="ArgumentException">The symbol of the extracted declaration is not an unqualified or invalid symbol.</exception>
484484
/// <exception cref="ArgumentException">The extracted declaration is Null.</exception>
485485
internal static HeaderEntry<T>? From(
486486
Func<CodeFragment, QsNullable<Tuple<QsSymbol, T>>> getDeclaration,
@@ -536,7 +536,7 @@ public FileHeader(ReaderWriterLockSlim syncRoot)
536536
/// updates all elements that are larger than or equal to start + count with the given lineNrChange.
537537
/// </summary>
538538
/// <exception cref="ArgumentOutOfRangeException">
539-
/// <paramref name="start"/> or <paramref name="count"/> are negative, or if <paramref name="lineNrChange"/> is smaller than -<paramref name="count"/>.
539+
/// <paramref name="start"/> or <paramref name="count"/> are negative, or <paramref name="lineNrChange"/> is smaller than -<paramref name="count"/>.
540540
/// </exception>
541541
public void InvalidateOrUpdate(int start, int count, int lineNrChange)
542542
{

src/QsCompiler/CompilationManager/FileContentManager.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ internal CodeLine GetLine(int index) =>
462462
/// <summary>
463463
/// Verify content update.
464464
/// </summary>
465-
/// <exception cref="ArgumentOutOfRangeException"><paramref name="start"/> and <paramref name="count"/> are not valid for the current file content, where <paramref name="count"/> needs to be at least one.</exception>
465+
/// <exception cref="ArgumentOutOfRangeException"><paramref name="start"/> and <paramref name="count"/> are not valid for the current file content, or <paramref name="count"/> is less than 1.</exception>
466466
/// <exception cref="ArgumentException">
467467
/// <paramref name="replacements"/> does not contain at least one element, or the indentation change is non-zero, or a replacement does not have a suitable line ending.
468468
/// </exception>

src/QsCompiler/CompilationManager/ScopeTracking.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -553,7 +553,7 @@ private static List<CodeLine> GetUpdatedLines(this IEnumerable<CodeLine> lines,
553553
/// </summary>
554554
/// <exception cref="ArgumentException"><paramref name="replacements"/> does not at least contain one <see cref="CodeLine"/>.</exception>
555555
/// <exception cref="ArgumentOutOfRangeException">
556-
/// The range defined by <paramref name="start"/> and <paramref name="count"/> is not within <paramref name="file"/>, where <paramref name="count"/> needs to be at least one.
556+
/// The range defined by <paramref name="start"/> and <paramref name="count"/> is not within <paramref name="file"/>, or <paramref name="count"/> is less than 1.
557557
/// </exception>
558558
private static IEnumerable<CodeLine>? ComputeUpdates(FileContentManager file, int start, int count, CodeLine[] replacements)
559559
{

0 commit comments

Comments
 (0)