Skip to content

add a delay on reconnect attempt, so that refreshed header does not cut webusb connection #11085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwunderl merged 2 commits into from
Feb 5, 2026
Merged

add a delay on reconnect attempt, so that refreshed header does not cut webusb connection #11085

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
786cac4
add a delay on reconnect attempt, so that refreshed header does not c…
jwunderl Feb 4, 2026
5e6d898
Merge branch 'master' into dev/jwunderl/delay-on-reconnect
jwunderl Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion webapp/src/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1925,7 +1925,13 @@ export class ProjectView
pxt.BrowserUtils.changeHash("#editor", true);
// Clear the focus.
document.getElementById("root").focus();
/* await */ cmds.maybeReconnectAsync(false, true);
/** TODO: Resolve race condition that makes this having a delay necessary.
* Without this delay, in some circumstances (e.g. extensions being added) the reconnect will go through
* but webusb state will be lost right afterwards and the download icon will change from webusb connected
* to normal save icon (with some inconsistency on whether clicking download automatically reconnects,
* or requires further attention in form of disconnect/reconnect or page refresh)
*/
/* await */ pxt.Util.delay(500).then(() => cmds.maybeReconnectAsync(false, true));
this.editorLoaded();
}
}
Expand Down
Loading