Reposition the dropdown div on a resize to fix issues with Android #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riknoll
reviewed
Nov 13, 2018
| * by a particular field. The primary position will be below the field, | ||
| * and the secondary position above the field. Drop-down will be | ||
| * constrained to the block's workspace. | ||
| * @param {Object} owner The object showing the drop-down |
There was a problem hiding this comment.
Changing to field for clarity.
riknoll
approved these changes
Nov 13, 2018
added 2 commits
November 12, 2018 17:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#158 recently was a similar fix that repositioned the WidgetDiv when a resize occurred rather than closing it, which fixed issues with editing text fields on Android when the keyboard popped up.
This PR adds a similar fix but for the Dropdown div so you're able to use the textdropdown field and other similar fields that focus on a text field which in turn pops up the keyboard.
I'm also trying to standardize the ways we show the dropdowndiv into two methods:
Field's should no longer directly call the dropdown.show method, and we should consider making it private at a later stage.
@rachel-fenichel @picklesrus FYI.