Skip to content

Fix editing text fields on Android. #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2018
Merged

Fix editing text fields on Android. #158

merged 1 commit into from
Oct 26, 2018

Conversation

samelhusseini
Copy link
Contributor

@samelhusseini samelhusseini commented Oct 26, 2018 •
edited
Loading

Keyboard makes us lose focus making editing impossible.

PXT-blockly PR of scratchfoundation/scratch-blocks#1743

Tested on Android 7.1.1

@samelhusseini samelhusseini requested a review from riknoll October 26, 2018 20:24
riknoll
riknoll approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@riknoll riknoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that was fast

@samelhusseini samelhusseini merged commit 0d0ee3c into develop Oct 26, 2018
@samelhusseini samelhusseini deleted the fixeditingonandroid branch October 26, 2018 20:36
@samelhusseini samelhusseini mentioned this pull request Oct 26, 2018
Merged
@samelhusseini samelhusseini mentioned this pull request Nov 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riknoll riknoll riknoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samelhusseini @riknoll