Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test-runner): allow viewport null values #7225

Merged
merged 1 commit into from
Jun 21, 2021
Merged

fix(test-runner): allow viewport null values #7225

merged 1 commit into from
Jun 21, 2021

Conversation

mxschmitt
Copy link
Member

Fixes #7223

JoelEinbinder
JoelEinbinder approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@JoelEinbinder JoelEinbinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, only typescript complains?

@mxschmitt
Copy link
Member Author

This works, only typescript complains?

Yes we have a strict undefined check in place:

playwright/src/test/index.ts

Lines 139 to 140 in 388c6f5

if (viewport !== undefined)
options.viewport = viewport;

@mxschmitt mxschmitt merged commit 4d0d392 into microsoft:master Jun 21, 2021
aslushnikov pushed a commit to aslushnikov/playwright that referenced this pull request Jun 25, 2021
@mxschmitt @aslushnikov
cherry-pick(release-1.12): allow viewport null values
3bc25b3 
PR microsoft#7225 SHA 4d0d392
@aslushnikov aslushnikov mentioned this pull request Jun 25, 2021
Merged
aslushnikov added a commit that referenced this pull request Jun 25, 2021
@aslushnikov @mxschmitt
cherry-pick(release-1.12): allow viewport null values (#7310)
dd153b3 
PR #7225 SHA 4d0d392

Co-authored-by: Max Schmitt <max@schmitt.mx>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelEinbinder JoelEinbinder JoelEinbinder approved these changes

@dgozman dgozman Awaiting requested review from dgozman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] test-runner viewport can't be null
2 participants
@mxschmitt @JoelEinbinder