New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] test-runner viewport can't be null #7223

Closed

mxschmitt opened this issue Jun 18, 2021 · 0 comments · Fixed by #7225

Labels

feature-test-runner

Member

mxschmitt commented Jun 18, 2021

    {
      name: 'Chromium',
      use: {
        browserName: 'chromium',
        // Make Chromium maximized
        // @ts-ignore
        viewport: null,
        launchOptions: {
          headless: false,
          args: ["--start-maximized"]
        },
      },
    },
  ],

See the ts-ignore.

If we go with the #7221 approach, then we don't have to fix that.

mxschmitt added P2-bug feature-test-runner labels

mxschmitt mentioned this issue

fix(test-runner): allow viewport null values #7225

Merged

mxschmitt closed this as completed in #7225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment