feat(chromium): basic drag and drop support #4519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelEinbinder
force-pushed
the
hack_drag_drop
branch
from
468d763
to
ad8973f
Compare
dgozman
reviewed
Nov 30, 2020
src/server/chromium/crPage.ts
Outdated
| await Promise.all(this._page.frames().map(frame => frame._evaluateExpression(binding.source, false, {}).catch(e => {}))); | ||
| } | ||
|
|
||
| async exposeInternalBinding(name: string, callback: frames.FunctionWithSource) { |
There was a problem hiding this comment.
I think we should move this to the common Page class.
| @@ -0,0 +1,115 @@ | |||
| /** | |||
There was a problem hiding this comment.
Let's make this a part of InjectedScript, but install the dragstart handler lazily as you do now.
| @@ -127,8 +127,8 @@ describe('Drag and drop', test => { | |||
| 'mousedown', | |||
| isFirefox ? 'dragstart' : 'mousemove', | |||
| isFirefox ? 'mousemove' : 'dragstart', | |||
| 'dragenter', | |||
| 'dragover', | |||
| // 'dragenter', | |||
JoelEinbinder
force-pushed
the
hack_drag_drop
branch
from
ad8973f
to
a9553c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does drag and drop for chromium in a very hacky way all in the client. It covers the fast majority of use cases. We can remove the majority of the code by adding a CDP method to attack drag data to the mouse and another to intercept the dragstart. The chromium patches involve a lot of tricky IPC races/security concerns, and so this hacky patch lets us take our time over there.
#1094
closes #4508