test(drag): more tests for drag and drop #4508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Nov 20, 2020
| await page.mouse.down(); | ||
| await page.hover('#target'); | ||
| await page.mouse.up(); | ||
| expect(await page.$eval('#target', target => target.contains(document.querySelector('#source')))).toBe(true); // could not find source in target |
There was a problem hiding this comment.
What does "could not find source in target" mean here?
There was a problem hiding this comment.
We use to have error messages after the error as a string, which was helpful when the test failed. When we moved to the expect library, these got removed. But the error reporter shows the line that failed now, so I just put a message in a comment after the line.
JoelEinbinder
force-pushed
the
drag_tests2
branch
from
01e5c25
to
2a56aeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a bunch more drag and drop tests. All set to fixme right now, but #4506 will turn on four for firefox. Chromium and Webkit patches are larger, but coming soon. The golden event orders here were tested against mostly working versions of patches in all browsers.