devops: test install over more node versions #1989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwoll
commented
Apr 27, 2020
Comment on lines
+4
to
+7
| - nodejs_version: "11" | ||
| - nodejs_version: "12" | ||
| - nodejs_version: "13" | ||
| - nodejs_version: "14" |
There was a problem hiding this comment.
I'm not sure what Node.js versions the Playwright team wants to officially support, so please modify this list as necessary.
rwoll
force-pushed
the
feature/ensure-last-several-node-version-support
branch
from
d5b8daa
to
cbc0c4f
Compare
rwoll
commented
Apr 27, 2020
| @@ -38,5 +38,8 @@ script: | |||
| - xvfb-run --auto-servernum npm run wtest | |||
| jobs: | |||
| include: | |||
| - node_js: '10' | |||
There was a problem hiding this comment.
Same comment applies here.
|
Closing in favor of determining what versions Playwright supports in #2059. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to #1988. It would be helpful to run tests in more Node environments to ensure compatibility with the most popular versions of node that are currently out.