Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] What versions of Node.js does Playwright support? #2059

Closed
rwoll opened this issue Apr 30, 2020 · 6 comments
Closed

[Question] What versions of Node.js does Playwright support? #2059

rwoll opened this issue Apr 30, 2020 · 6 comments

Comments

@rwoll
Copy link
Member

rwoll commented Apr 30, 2020

What version(s) of Node.js does Playwright official support?

See #1988 and #1989 for related issues/MRs.

If there is an official supported version set, I'll re-open #1989; if there's no official set, please mark this issue as closed.

@mxschmitt
Copy link
Member

Hey, #1988 was a bug in Node.js 14 (which should be normally very rare) and in general Playwright supports Node.js 10.15+ see here which will be also covered soon on the website.

@rwoll
Copy link
Member Author

rwoll commented Apr 30, 2020

Is it helpful to have the checks in #1989 to ensure the compatibility guarantees, or does that mostly just slow down builds without much benefit since #1988 bugs are likely rare?

I also may be missing a CI config where Playwright already does an equivalent build matrix proposed in #1989.

@aslushnikov
Copy link
Contributor

aslushnikov commented Apr 30, 2020

We target earliest Active LTS Node.js version - which is currently 12. I wouldn't run all our tests on all node.js versions - that's probably too much, but we can run smoke tests on even node.js versions.

We already have test-package-installations tests that verify that playwright installs and runs a simple playwright script. I'd run this on node 14 as well.

@rwoll are you interested in contributing this?

@rwoll
Copy link
Member Author

rwoll commented May 1, 2020

@rwoll are you interested in contributing this?

Yes, I'll take a look!

@jevgenijusmarinuskinas
Copy link

jevgenijusmarinuskinas commented Oct 5, 2021

@aslushnikov ,it is still relevant. I am getting an error when running npx playwright install on Node 10.16.3:
Does this mean Playwright is no longer compatible with Node version 10? On 14 everything is fine.

PS C:\Users\t\Documents\Projects\test> npx playwright install
C:\Users\t\Documents\Projects\test\node_modules\@playwright\test\lib\grid\gridServer.js:143
  constructor(capacity = Infinity, creationTimeout = 5 * 60_000) {
                                                         ^^

SyntaxError: Invalid or unexpected token
    at Module._compile (internal/modules/cjs/loader.js:723:23)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (C:\Users\t\Documents\Projects\test\node_modules\@playwright\test\lib\cli\cli.js:42:19)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
    at startup (internal/bootstrap/node.js:283:19)

@mxschmitt
Copy link
Member

mxschmitt commented Oct 5, 2021

@jevgenijusmarinuskinas Node.js 12+ is required. Node.js 10 is not supported anymore by Node.js and we only support maintained versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants