devops: add package-lock.json #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to commit `package-lock.json` to repository to ensure reproducible builds. This also starts using [`npm ci`](https://docs.npmjs.com/cli/ci.html) to install dependencies. Drive-by: remove non-functioning `rebase` workflow.
yury-s
approved these changes
Apr 18, 2020
pavelfeldman
added a commit
that referenced
this pull request
Apr 19, 2020
This reverts commit 75f35e4. It is unclear how to add/remove dependencies now.
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this pull request
Apr 20, 2020
We need to commit `package-lock.json` to repository to ensure reproducible builds. This also starts using [`npm ci`](https://docs.npmjs.com/cli/ci.html) to install dependencies. Drive-by: remove non-functioning `rebase` workflow.
aslushnikov
added a commit
that referenced
this pull request
Apr 20, 2020
We need to commit `package-lock.json` to repository to ensure reproducible builds. This also starts using [`npm ci`](https://docs.npmjs.com/cli/ci.html) to install dependencies. Drive-by: remove non-functioning `rebase` workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to commit
package-lock.jsonto repository to ensurereproducible builds.
This also starts using
npm citoinstall dependencies.
Drive-by: remove non-functioning
rebaseworkflow.