Skip to content

Commit

Permalink
devops: add package-lock.json (#1859) (#1889)
Browse files Browse the repository at this point in the history
We need to commit `package-lock.json` to repository to ensure
reproducible builds.

This also starts using [`npm ci`](https://docs.npmjs.com/cli/ci.html) to
install dependencies.

Drive-by: remove non-functioning `rebase` workflow.
  • Loading branch information
aslushnikov authored Apr 20, 2020
1 parent c2fe55e commit 1935824
Show file tree
Hide file tree
Showing 8 changed files with 5,784 additions and 38 deletions.
2 changes: 1 addition & 1 deletion .appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ build: off

install:
- ps: Install-Product node $env:nodejs_version
- npm install
- npm ci
- npm run ctest
- npm run wtest
- npm run ftest
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
key: dependency-cache-{{ checksum "package.json" }}

- run:
command: npm install
command: npm ci

- save_cache:
key: dependency-cache-{{ checksum "package.json" }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/infra.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ jobs:
sudo apt-get update
sudo apt-get install libgbm-dev
sudo apt-get install xvfb
- run: npm install
- run: npm ci
- run: npm run lint
24 changes: 0 additions & 24 deletions .github/workflows/rebase.yml

This file was deleted.

20 changes: 10 additions & 10 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: install xvfb
run: |
sudo apt-get install xvfb
- run: npm install
- run: npm ci
# XVFB-RUN merges both STDOUT and STDERR, whereas we need only STDERR
# Wrap `npm run` in a subshell to redirect STDERR to file.
- run: xvfb-run --auto-servernum -- bash -c "npm run ccoverage 2>./chromium-linux-testrun.log"
Expand Down Expand Up @@ -55,7 +55,7 @@ jobs:
with:
node-version: 10
- uses: microsoft/playwright-github-action@v1
- run: npm install
- run: npm ci
- run: npm run ctest 2>./chromium-mac-testrun.log
env:
DEBUG: "*"
Expand All @@ -82,7 +82,7 @@ jobs:
with:
node-version: 10
- uses: microsoft/playwright-github-action@v1
- run: npm install
- run: npm ci
- run: npm run ctest 2>./chromium-win-testrun.log
shell: bash
env:
Expand Down Expand Up @@ -113,7 +113,7 @@ jobs:
- name: install xvfb
run: |
sudo apt-get install xvfb
- run: npm install
- run: npm ci
# XVFB-RUN merges both STDOUT and STDERR, whereas we need only STDERR
# Wrap `npm run` in a subshell to redirect STDERR to file.
- run: xvfb-run --auto-servernum -- bash -c "npm run wcoverage 2>./webkit-linux-testrun.log"
Expand Down Expand Up @@ -142,7 +142,7 @@ jobs:
with:
node-version: 10
- uses: microsoft/playwright-github-action@v1
- run: npm install
- run: npm ci
- run: npm run wtest 2>./webkit-mac-testrun.log
env:
DEBUG: "*,-pw:wrapped*"
Expand All @@ -169,7 +169,7 @@ jobs:
with:
node-version: 10
- uses: microsoft/playwright-github-action@v1
- run: npm install
- run: npm ci
- run: npm run wtest 2>./webkit-win-testrun.log
shell: bash
env:
Expand Down Expand Up @@ -200,7 +200,7 @@ jobs:
- name: install xvfb
run: |
sudo apt-get install xvfb
- run: npm install
- run: npm ci
# XVFB-RUN merges both STDOUT and STDERR, whereas we need only STDERR
# Wrap `npm run` in a subshell to redirect STDERR to file.
- run: xvfb-run --auto-servernum -- bash -c "npm run fcoverage 2>./firefox-linux-testrun.log"
Expand Down Expand Up @@ -229,7 +229,7 @@ jobs:
with:
node-version: 10
- uses: microsoft/playwright-github-action@v1
- run: npm install
- run: npm ci
- run: npm run ftest 2>./firefox-mac-testrun.log
env:
DEBUG: "*"
Expand All @@ -256,7 +256,7 @@ jobs:
with:
node-version: 10
- uses: microsoft/playwright-github-action@v1
- run: npm install
- run: npm ci
- run: npm run ftest 2>./firefox-win-testrun.log
shell: bash
env:
Expand Down Expand Up @@ -285,5 +285,5 @@ jobs:
# we use in `installation-tests.sh`.
node-version: 12
- uses: microsoft/playwright-github-action@v1
- run: npm install
- run: npm ci
- run: bash test/installation-tests/installation-tests.sh
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
*.swp
*.pyc
.vscode
package-lock.json
yarn.lock
/node6
/src/generated/*
Expand Down
2 changes: 2 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ addons:
- xvfb
notifications:
email: false
install:
- npm ci
cache:
directories:
- node_modules
Expand Down
Loading

0 comments on commit 1935824

Please sign in to comment.