Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rel-1.8.1][Objective-C API] Cherry-pick Objective-C API updates #8197

Merged

Conversation

edgchen1
Copy link
Contributor

Description
Cherry-pick these changes:
[Objective-C API] Add support for documentation generation (#7999)
[Objective-C API] Add script to assemble pod package files. (#7958)
[Objective-C API] Enable CoreML EP (#7914)
[Objective-C API] Fixes from package testing and clean up (#7866)
[Objective-C API] Add ORTSession methods to get input, overridable initializer, and output names. (#7837)

Motivation and Context
Releasing Objective-C API package in 1.8.1.

edgchen1 added 5 commits June 29, 2021 18:05
Enable CoreML EP in Objective-C API.
Add a helper script for creating the Objective-C API pod package. It puts the necessary files and generates a podspec in a staging directory.
Adding support for generating API documentation with the Jazzy tool.
It's a manual process now, but we can eventually make it a part of the release pipeline.
@edgchen1 edgchen1 requested a review from a team as a code owner June 30, 2021 01:37
Copy link
Contributor

@guoyu-wang guoyu-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the doc generating change to be in 1.8.1? I guess it's ok if it's hard to separate the change

@edgchen1
Copy link
Contributor Author

Do we need the doc generating change to be in 1.8.1? I guess it's ok if it's hard to separate the change

That one is not strictly required, but it did include a change to improve documentation. I just picked commits from the objectivec directory history.

@edgchen1 edgchen1 changed the base branch from rel-1.8.1 to havenka/rel-1.8.1-round3 June 30, 2021 17:22
@edgchen1 edgchen1 requested a review from harshithapv June 30, 2021 17:22
@harshithapv harshithapv merged commit 15fb602 into havenka/rel-1.8.1-round3 Jun 30, 2021
@harshithapv harshithapv deleted the edgchen1/rel-1.8.1/objc_api_updates branch June 30, 2021 17:48
harshithapv added a commit that referenced this pull request Jun 30, 2021
* Revert the cuda algo finding change as this causes a significant memory bloat. (#8181)

* Revert the cuda algo finding change as this causes a significant memory bloat.

* Address PR comment

* Make pipelines to support torch1.8.1 and torch1.9.0 (#8084)

* Add post-install command to build PyTorch CPP extensions from within onnxruntime package (#8027)

ORTModule requires two PyTorch CPP extensions that are currently JIT compiled. The runtime compilation can cause issues in some environments without all build requirements or in environments with multiple instances of ORTModule running in parallel

This PR creates a custom command to compile such extensions that must be manually executed before ORTModule is executed for the first time. When users try to use ORTModule before the extensions are compiled, an error with instructions are raised

PyTorch CPP Extensions for ORTModule can be compiled by running:
python -m onnxruntime.training.ortmodule.torch_cpp_extensions.install

Full build environment is needed for this

* Patch orttraining-ortmodule pipeline with latest fix on master

* add cuda version to build config

* [rel-1.8.1][Objective-C API] Cherry-pick Objective-C API updates (#8197)

* [Objective-C API] Add ORTSession methods to get input, overridable initializer, and output names. (#7837)

* [Objective-C API] Fixes from package testing and clean up (#7866)

* [Objective-C API] Enable CoreML EP (#7914)

Enable CoreML EP in Objective-C API.

* [Objective-C API] Add script to assemble pod package files. (#7958)

Add a helper script for creating the Objective-C API pod package. It puts the necessary files and generates a podspec in a staging directory.

* [Objective-C API] Add support for documentation generation (#7999)

Adding support for generating API documentation with the Jazzy tool.
It's a manual process now, but we can eventually make it a part of the release pipeline.

Co-authored-by: Pranav Sharma <prs@microsoft.com>
Co-authored-by: liqunfu <liqfu@microsoft.com>
Co-authored-by: Thiago Crepaldi <thiago.crepaldi@microsoft.com>
Co-authored-by: Baiju Meswani <bmeswani@microsoft.com>
Co-authored-by: Edward Chen <18449977+edgchen1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants