[Objective-C API] Add script to assemble pod package files. #7958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgchen1
commented
Jun 5, 2021
| "${OBJC_ROOT}/include/ort_value.h" | ||
| ) | ||
| file(GLOB onnxruntime_objc_headers CONFIGURE_DEPENDS | ||
| "${OBJC_ROOT}/include/*.h") |
There was a problem hiding this comment.
now that we have to specify this in two places, it's less maintenance to just match everything in the include directory
guoyu-wang
reviewed
Jun 7, 2021
| podspec_template = _script_dir / "onnxruntime-mobile-objc.podspec.template" | ||
| podspec = staging_dir / "onnxruntime-mobile-objc.podspec" | ||
| gen_file_from_template(podspec_template, podspec, variable_substitutions) | ||
|
|
There was a problem hiding this comment.
Curious, do you want to create the zip archive here as well?
There was a problem hiding this comment.
I think zipping and uploading would happen at a later point, after testing the package. Once we have this staging directory, we can run pod lib lint in it to test it.
guoyu-wang
reviewed
Jun 7, 2021
guoyu-wang
reviewed
Jun 7, 2021
| s.default_subspec = "Core" | ||
|
|
||
| s.subspec "Core" do |core| | ||
| core.dependency "onnxruntime-mobile-c", "#{s.version}" |
There was a problem hiding this comment.
If this depends on the same version number, maybe you can extract that out of the VERSION_NUMBER file, instead of supply it as a param to the script?
Not sure how it works at our current setup, ort-mobile-c ~> 1.8.0 ort-mobile-objc ~> 1.8.0-experimental
There was a problem hiding this comment.
Not sure what the best approach is yet - getting it from VERSION_NUMBER would only work for release versions right? But I think most of the time the versions of the C/C++ and Objective-C pods should be the same. Will go with this for now.
guoyu-wang
approved these changes
Jun 7, 2021
edgchen1
added a commit
that referenced
this pull request
Jun 30, 2021
Add a helper script for creating the Objective-C API pod package. It puts the necessary files and generates a podspec in a staging directory.
harshithapv
pushed a commit
that referenced
this pull request
Jun 30, 2021
* [Objective-C API] Add ORTSession methods to get input, overridable initializer, and output names. (#7837) * [Objective-C API] Fixes from package testing and clean up (#7866) * [Objective-C API] Enable CoreML EP (#7914) Enable CoreML EP in Objective-C API. * [Objective-C API] Add script to assemble pod package files. (#7958) Add a helper script for creating the Objective-C API pod package. It puts the necessary files and generates a podspec in a staging directory. * [Objective-C API] Add support for documentation generation (#7999) Adding support for generating API documentation with the Jazzy tool. It's a manual process now, but we can eventually make it a part of the release pipeline.
harshithapv
added a commit
that referenced
this pull request
Jun 30, 2021
* Revert the cuda algo finding change as this causes a significant memory bloat. (#8181) * Revert the cuda algo finding change as this causes a significant memory bloat. * Address PR comment * Make pipelines to support torch1.8.1 and torch1.9.0 (#8084) * Add post-install command to build PyTorch CPP extensions from within onnxruntime package (#8027) ORTModule requires two PyTorch CPP extensions that are currently JIT compiled. The runtime compilation can cause issues in some environments without all build requirements or in environments with multiple instances of ORTModule running in parallel This PR creates a custom command to compile such extensions that must be manually executed before ORTModule is executed for the first time. When users try to use ORTModule before the extensions are compiled, an error with instructions are raised PyTorch CPP Extensions for ORTModule can be compiled by running: python -m onnxruntime.training.ortmodule.torch_cpp_extensions.install Full build environment is needed for this * Patch orttraining-ortmodule pipeline with latest fix on master * add cuda version to build config * [rel-1.8.1][Objective-C API] Cherry-pick Objective-C API updates (#8197) * [Objective-C API] Add ORTSession methods to get input, overridable initializer, and output names. (#7837) * [Objective-C API] Fixes from package testing and clean up (#7866) * [Objective-C API] Enable CoreML EP (#7914) Enable CoreML EP in Objective-C API. * [Objective-C API] Add script to assemble pod package files. (#7958) Add a helper script for creating the Objective-C API pod package. It puts the necessary files and generates a podspec in a staging directory. * [Objective-C API] Add support for documentation generation (#7999) Adding support for generating API documentation with the Jazzy tool. It's a manual process now, but we can eventually make it a part of the release pipeline. Co-authored-by: Pranav Sharma <prs@microsoft.com> Co-authored-by: liqunfu <liqfu@microsoft.com> Co-authored-by: Thiago Crepaldi <thiago.crepaldi@microsoft.com> Co-authored-by: Baiju Meswani <bmeswani@microsoft.com> Co-authored-by: Edward Chen <18449977+edgchen1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a helper script for creating the Objective-C API pod package. It puts the necessary files and generates a podspec in a staging directory.
Motivation and Context
Automate Objective-C API package creation.