Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Conversation

@Porges
Copy link
Member

@Porges Porges commented Jul 24, 2023

This reverts commit 25f1257.

The change broke the libfuzzer dotnet template (I could have sworn I validated first with check-pr but…)

Two things didn't work:

  1. the path to the LibFuzzerDotNetLoader needed to change; I attempted to fix this in Fix .NET template  #3324
  2. minidumps weren't being captured, for an unknown reason. I haven't figured out why yet, thus I'm going to simply revert the change so we have this working for the next release.

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

Codecov Report

Merging #3327 (ffa71b6) into main (2d0d297) will decrease coverage by 1.40%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3327      +/-   ##
==========================================
- Coverage   31.81%   30.41%   -1.40%     
==========================================
  Files         307      133     -174     
  Lines       37327    14278   -23049     
==========================================
- Hits        11874     4343    -7531     
+ Misses      25453     9935   -15518     

see 174 files with indirect coverage changes

@Porges Porges marked this pull request as ready for review July 24, 2023 20:38
@Porges Porges enabled auto-merge (squash) July 24, 2023 21:13
@Porges Porges merged commit e68fc45 into main Jul 24, 2023
@Porges Porges deleted the revert-lfdnl branch July 24, 2023 21:37
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants