This repository was archived by the owner on Nov 1, 2023. It is now read-only.
Update packaging of LibFuzzerDotNetLoader #3248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3248 +/- ##
=======================================
Coverage 31.45% 31.45%
=======================================
Files 307 307
Lines 37202 37202
=======================================
Hits 11703 11703
Misses 25499 25499 |
Porges
changed the title
Porges
changed the title
Porges
changed the title
tevoinea
approved these changes
Jun 29, 2023
Closed
Porges
added a commit
that referenced
this pull request
Jul 24, 2023
This reverts commit 25f1257. The change broke the libfuzzer dotnet template (I could have sworn I validated first with check-pr but…) Two things didn't work: 1. the path to the LibFuzzerDotNetLoader needed to change; I attempted to fix this in #3324 2. minidumps weren't being captured, for an unknown reason. I haven't figured out why yet, thus I'm going to simply revert the change so we have this working for the next release.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make them a bit smaller by packaging into single files and enabling invariant-globalization mode.