Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Conversation

@chkeita
Copy link
Contributor

@chkeita chkeita commented May 5, 2023

Summary of the Pull Request

This is refactoring of our log uploading process.

  • The process that upload the logs lives with the agent instead of the task
  • The task now logs to a file and to the console.
  • The task log file is synchronized to the log container periodically

WIP refactoring log upload
@chkeita chkeita changed the title WIP refactoring log upload [WIP] refactoring log upload May 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2023

Codecov Report

Merging #3087 (3f7fd27) into main (760e7d6) will decrease coverage by 1.86%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3087      +/-   ##
==========================================
- Coverage   31.82%   29.97%   -1.86%     
==========================================
  Files         307      127     -180     
  Lines       36782    13896   -22886     
==========================================
- Hits        11707     4165    -7542     
+ Misses      25075     9731   -15344     

see 179 files with indirect coverage changes

@chkeita chkeita changed the title [WIP] refactoring log upload Refactoring log upload May 15, 2023
@chkeita chkeita requested review from Porges and tevoinea May 15, 2023 20:11
@chkeita chkeita marked this pull request as ready for review May 15, 2023 21:03
@chkeita chkeita enabled auto-merge (squash) May 16, 2023 17:43
@chkeita chkeita disabled auto-merge May 16, 2023 17:43
@chkeita chkeita enabled auto-merge (squash) May 16, 2023 18:50
@chkeita chkeita disabled auto-merge May 16, 2023 18:50
@chkeita chkeita enabled auto-merge (squash) May 16, 2023 18:51
@chkeita chkeita merged commit f6473c6 into microsoft:main May 16, 2023
@chkeita chkeita linked an issue May 17, 2023 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task logger seem to stop before the task is completed

3 participants