Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Conversation

@nharper285
Copy link
Contributor

Summary of the Pull Request

What is this about?
Removing remaining -net references in deployment and agent code.

PR Checklist

  • Applies to work item: Remove -net App Function Deployment Code #2676
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022

Codecov Report

Merging #2682 (21e848b) into main (0fb8bc4) will increase coverage by 0.96%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2682      +/-   ##
==========================================
+ Coverage   28.64%   29.60%   +0.96%     
==========================================
  Files         308      272      -36     
  Lines       37662    31416    -6246     
==========================================
- Hits        10787     9302    -1485     
+ Misses      26875    22114    -4761     
Impacted Files Coverage Δ
src/agent/onefuzz/src/machine_id.rs 11.53% <0.00%> (-8.98%) ⬇️
src/agent/coverage-legacy/src/test.rs 92.85% <0.00%> (-7.15%) ⬇️
src/agent/onefuzz/src/sanitizer.rs 68.65% <0.00%> (-2.97%) ⬇️
src/agent/onefuzz-agent/src/worker/tests.rs 99.10% <0.00%> (-0.11%) ⬇️
src/agent/onefuzz/src/asan.rs 0.00% <0.00%> (ø)
src/agent/onefuzz-agent/src/setup.rs 0.00% <0.00%> (ø)
src/agent/onefuzz-agent/src/reboot.rs 0.00% <0.00%> (ø)
src/agent/onefuzz/src/input_tester.rs 0.00% <0.00%> (ø)
src/agent/coverage-legacy/src/cache.rs 0.00% <0.00%> (ø)
src/agent/onefuzz-agent/src/commands.rs 0.00% <0.00%> (ø)
... and 48 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nharper285 nharper285 marked this pull request as ready for review December 9, 2022 00:14
Copy link
Contributor

@mgreisen mgreisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nharper285 nharper285 merged commit 349604f into microsoft:main Dec 16, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jan 15, 2023
@mgreisen
Copy link
Contributor

closes #2676

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants