Skip to content

FEAT: PDB File generation to make Private symbols for DDBC Bindings #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

FEAT: PDB File generation to make Private symbols for DDBC Bindings #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
591417f
FEAT: PDB File generation to make Private symbols for DDBC Bindings
bewithgaurav Jun 9, 2025
57a6c8c
resolved merge conflict
bewithgaurav Jun 9, 2025
c534492
Debugging for PDB copying duplicates
bewithgaurav Jun 10, 2025
9dbf24c
fixed variable issue and push as artifact
bewithgaurav Jun 10, 2025
c0e8a6c
add PDBs in build whl artifacts
bewithgaurav Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
# Ignore all files in the pybind/build directory
mssql_python/pybind/build/

mssql_python/pybind/pymsbuild/build/

# Ignore pyd file
mssql_python/ddbc_bindings.pyd

# Ignore pycache files and folders
__pycache__/
**/__pycache__/
Expand Down Expand Up @@ -43,6 +38,7 @@ build/
# C extensions
*.so
*.pyd
*.pdb

# IDE files
.vscode/
Expand Down
8 changes: 8 additions & 0 deletions eng/pipelines/build-whl-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,14 @@ jobs:
TargetFolder: '$(Build.ArtifactStagingDirectory)\all-pyds'
displayName: 'Place PYD file into artifacts directory'

# Copy the built .pdb files to staging folder for artifacts
- task: CopyFiles@2
inputs:
SourceFolder: '$(Build.SourcesDirectory)\mssql_python\pybind\build\$(targetArch)\py$(shortPyVer)\Release'
Contents: 'ddbc_bindings.cp$(shortPyVer)-*.pdbs'
TargetFolder: '$(Build.ArtifactStagingDirectory)\all-pdbs'
displayName: 'Place PDB file into artifacts directory'

# Build wheel package for the current architecture
- script: |
python -m pip install --upgrade pip
Expand Down
7 changes: 7 additions & 0 deletions eng/pipelines/pr-validation-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,13 @@ jobs:
publishLocation: 'Container'
displayName: 'Publish pyd file as artifact'

- task: PublishBuildArtifacts@1
inputs:
PathtoPublish: 'mssql_python/ddbc_bindings.cp313-amd64.pdb'
ArtifactName: 'ddbc_bindings'
publishLocation: 'Container'
displayName: 'Publish pdb file as artifact'

- task: PublishTestResults@2
condition: succeededOrFailed()
inputs:
Expand Down
14 changes: 14 additions & 0 deletions mssql_python/pybind/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ project(ddbc_bindings)
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)

if (MSVC)
# Enable PDB generation for all target types
add_compile_options("$<$<CONFIG:Release>:/Zi>")
add_link_options("$<$<CONFIG:Release>:/DEBUG /OPT:REF /OPT:ICF>")
Comment on lines +9 to +11
Copy link
Preview

Copilot AI Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider scoping these compile and link options to the ddbc_bindings target (using target_compile_options and target_link_options) instead of globally to avoid unintended effects on other targets.

Suggested change
# Enable PDB generation for all target types
add_compile_options("$<$<CONFIG:Release>:/Zi>")
add_link_options("$<$<CONFIG:Release>:/DEBUG /OPT:REF /OPT:ICF>")
# Enable PDB generation for the ddbc_bindings target
target_compile_options(ddbc_bindings PRIVATE "$<$<CONFIG:Release>:/Zi>")
target_link_options(ddbc_bindings PRIVATE "$<$<CONFIG:Release>:/DEBUG /OPT:REF /OPT:ICF>")

Copilot uses AI. Check for mistakes.

endif()

# Detect platform
if(WIN32)
set(PLATFORM_NAME "windows")
Expand All @@ -19,6 +25,7 @@ endif()
# Set default architecture if not provided
if(NOT DEFINED ARCHITECTURE)
if(WIN32)
# Default to x64 for Windows
set(ARCHITECTURE "win64")
elseif(APPLE)
# Check if we're on Apple Silicon or Intel
Expand Down Expand Up @@ -207,6 +214,13 @@ set_target_properties(ddbc_bindings PROPERTIES
OUTPUT_NAME "ddbc_bindings.cp${PYTHON_VERSION}-${WHEEL_ARCH}"
SUFFIX "${MODULE_EXTENSION}"
)
# Ensure PDB is generated in Release
set_target_properties(ddbc_bindings PROPERTIES
COMPILE_PDB_NAME "ddbc_bindings.cp${PYTHON_VERSION}-${WHEEL_ARCH}"
COMPILE_PDB_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}"
PDB_NAME "ddbc_bindings.cp${PYTHON_VERSION}-${WHEEL_ARCH}"
PDB_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}"
)

# Include directories for all architectures
if(NOT DEFINED ODBC_INCLUDE_DIR)
Expand Down
15 changes: 14 additions & 1 deletion mssql_python/pybind/build.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,20 @@ set OUTPUT_DIR=%BUILD_DIR%\Release

if exist "%OUTPUT_DIR%\%PYD_NAME%" (
copy /Y "%OUTPUT_DIR%\%PYD_NAME%" "%SOURCE_DIR%\.."
echo [SUCCESS] Copied %PYD_NAME% to %SOURCE_DIR%..
echo [SUCCESS] Copied %PYD_NAME% to %SOURCE_DIR%\..

echo [DIAGNOSTIC] Copying PDB file if it exists...
set PDB_NAME=ddbc_bindings.cp%PYTAG%-%WHEEL_ARCH%.pdb
echo [DEBUG] Computed PDB_NAME: !PDB_NAME!

if exist "%OUTPUT_DIR%\!PDB_NAME!" (
echo [DIAGNOSTIC] Found PDB file: "!PDB_NAME!"
echo [DIAGNOSTIC] Copying PDB file to source directory...
copy /Y "%OUTPUT_DIR%\!PDB_NAME!" "%SOURCE_DIR%\.."
echo [SUCCESS] Copied !PDB_NAME! to %SOURCE_DIR%..
) else (
echo [WARNING] PDB file !PDB_NAME! not found in output directory.
)

setlocal enabledelayedexpansion
for %%I in ("%SOURCE_DIR%..") do (
Expand Down
Loading