FEAT: PDB File generation to make Private symbols for DDBC Bindings #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces changes to improve debugging support for the
ddbc_bindings
project by enabling PDB (Program Database) file generation and ensuring proper handling of these files during the build process. The changes primarily focus on updating the CMake configuration and build script.Debugging Support Improvements:
Enabled PDB generation for MSVC builds in Release mode: Added compile and link options in
CMakeLists.txt
to ensure PDB files are generated when building with MSVC in Release mode. (mssql_python/pybind/CMakeLists.txt
, mssql_python/pybind/CMakeLists.txtR8-R13)Configured PDB properties for
ddbc_bindings
target: Set properties inCMakeLists.txt
to specify the PDB file name and output directory for theddbc_bindings
target. (mssql_python/pybind/CMakeLists.txt
, mssql_python/pybind/CMakeLists.txtR113-R119)Handled PDB file copying in build script: Updated
build.bat
to check for the existence of the PDB file after the build, copy it to the appropriate directory if found, and log diagnostic messages for success or warnings if the file is missing. (mssql_python/pybind/build.bat
, mssql_python/pybind/build.batR147-R155)Issue Reference
Fixes AB#37472
Solution Implemented
CMakeLists
andbuild.bat
to generate a PDB file for releaseChecklist
Testing Performed
3.13.3
Windows