Skip to content

fix build failures and also update to scikit-learn OneHotEncoder sparse parameter to sparse_output for newer scikit-learn versions#175

Merged
imatiach-msft merged 1 commit into
microsoft:mainfrom
imatiach-msft:ilmat/fix-ohe-sparse-param
Aug 20, 2024
Merged

fix build failures and also update to scikit-learn OneHotEncoder sparse parameter to sparse_output for newer scikit-learn versions#175
imatiach-msft merged 1 commit into
microsoft:mainfrom
imatiach-msft:ilmat/fix-ohe-sparse-param

Conversation

@imatiach-msft

@imatiach-msft imatiach-msft commented May 30, 2024

Copy link
Copy Markdown
Contributor

fix build failures and also update to scikit-learn OneHotEncoder sparse parameter to sparse_output for newer scikit-learn versions

Contains several updates to latest azureml automl package, updates to use python 3.9 as default env in tests, and various updates to newer packages to resolve test failures.

Copilot summary:

This pull request includes various updates to the CI workflows, dependencies, and test configurations to improve compatibility and functionality. The most important changes focus on updating Python and package versions, modifying CI workflows, and addressing compatibility issues in the codebase.

CI Workflow Updates:

Dependency Updates:

  • requirements-dev.txt and requirements-automl.txt: Updated transformers version constraint and removed azureml-automl-core. [1] [2] [3] [4]
  • python/setup.py: Added packaging and restricted numpy to versions below 2.0.0.

Code Compatibility:

  • python/ml_wrappers/dataset/dataset_wrapper.py: Added version check for sklearn to handle changes in OneHotEncoder parameters.
  • tests/automl/test_automl_image_model_wrapper.py and tests/automl/test_automl_image_object_detection_model_wrapper.py: Updated Python version constraints and package versions for compatibility with azureml-automl-dnn-vision. [1] [2] [3] [4]

Test Configuration:

  • tests/main/test_model_wrapper.py and tests/main/test_tf_model_wrapper.py: Skipped tests for Keras API due to compatibility issues with the latest TensorFlow. [1] [2]
  • tests/main/test_text_model_wrapper.py: Skipped test for transformers model due to changes in text pair support.

Miscellaneous:

  • Updated URLs in tests/common_vision_utils.py for downloading datasets. [1] [2] [3]

@codecov-commenter

codecov-commenter commented Jun 7, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 33.20%. Comparing base (06df9af) to head (f323622).

Files Patch % Lines
python/ml_wrappers/dataset/dataset_wrapper.py 33.33% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (06df9af) and HEAD (f323622). Click for more details.

HEAD has 16 uploads less than BASE
Flag BASE (06df9af) HEAD (f323622)
unittests 17 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
- Coverage   41.66%   33.20%   -8.46%     
==========================================
  Files          27       26       -1     
  Lines        1884     1864      -20     
==========================================
- Hits          785      619     -166     
- Misses       1099     1245     +146     
Flag Coverage Δ
unittests 33.20% <33.33%> (-8.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imatiach-msft
imatiach-msft force-pushed the ilmat/fix-ohe-sparse-param branch 3 times, most recently from b88f27a to 485e61a Compare June 7, 2024 22:14
@imatiach-msft
imatiach-msft force-pushed the ilmat/fix-ohe-sparse-param branch 11 times, most recently from 63d192e to 4a04775 Compare August 20, 2024 19:54
@imatiach-msft imatiach-msft changed the title update scikit-learn OneHotEncoder sparse parameter to sparse_output for newer scikit-learn versions fix build failures and also update to scikit-learn OneHotEncoder sparse parameter to sparse_output for newer scikit-learn versions Aug 20, 2024
@imatiach-msft
imatiach-msft force-pushed the ilmat/fix-ohe-sparse-param branch 2 times, most recently from d07a530 to b851df7 Compare August 20, 2024 20:38
@imatiach-msft
imatiach-msft merged commit eb571a5 into microsoft:main Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants