Skip to content

Relax Pandas dependency requirement to allow >v2#596

Merged
imatiach-msft merged 2 commits into
interpretml:mainfrom
NatanMish:relax-pandas-version-requirement
Jun 4, 2024
Merged

Relax Pandas dependency requirement to allow >v2#596
imatiach-msft merged 2 commits into
interpretml:mainfrom
NatanMish:relax-pandas-version-requirement

Conversation

@NatanMish

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Natan Mish <natan.mish@zimmerbiomet.com>
@NatanMish
NatanMish force-pushed the relax-pandas-version-requirement branch from 0489ed5 to ff1e9f0 Compare May 30, 2024 15:18
@imatiach-msft

Copy link
Copy Markdown
Collaborator

looks like there were some flake8 errors in the build due to updates to dependencies - I am guessing this needs a separate PR, let me send one out

@NatanMish

Copy link
Copy Markdown
Contributor Author

Link to issue: #595

@imatiach-msft

Copy link
Copy Markdown
Collaborator

I sent a PR here to fix the flake8 errors:
#597

@imatiach-msft

Copy link
Copy Markdown
Collaborator

I also updated the PR to pin scikit-learn as I see one of the tests started failing with scikit-learn 1.5.0 release

@imatiach-msft

Copy link
Copy Markdown
Collaborator

@NatanMish please rebase this PR against latest main, I've merged PR #597 to fix the build errors

@imatiach-msft

Copy link
Copy Markdown
Collaborator

close re-open to re-run notebook tests

@imatiach-msft

Copy link
Copy Markdown
Collaborator

although the build is green it doesn't look like we are testing against pandas >2.0?

@imatiach-msft

Copy link
Copy Markdown
Collaborator

image

@imatiach-msft

imatiach-msft commented Jun 3, 2024

Copy link
Copy Markdown
Collaborator

seems like something else is still pinning it to older version in tests, strange

@NatanMish

Copy link
Copy Markdown
Contributor Author

@imatiach-msft Thanks for looking into this. I have never contributed to this project before. What would you suggest for the next steps?

@imatiach-msft

Copy link
Copy Markdown
Collaborator

@NatanMish maybe for now I will go ahead and merge this. My suspicion is that the ml-wrappers library that interpret-community depends on is bringing in this pandas<2.0 dependency, so we need to fix it there as well.

@imatiach-msft
imatiach-msft merged commit 71f4f38 into interpretml:main Jun 4, 2024
@NatanMish

Copy link
Copy Markdown
Contributor Author

Great thank you, when is the next planned release?

@imatiach-msft

Copy link
Copy Markdown
Collaborator

I think we still need to resolve the issue in ml-wrappers first. However, the build seems to be broken there right now as well based on PR microsoft/ml-wrappers#175, which may take some work.

@imatiach-msft

Copy link
Copy Markdown
Collaborator

Otherwise we are de facto still pulling and using the pinned version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants