Remove onnxruntime<=1.20.1 Windows pin#1551
Open
basnijholt wants to merge 1 commit intomicrosoft:mainfrom
Open
Remove onnxruntime<=1.20.1 Windows pin#1551basnijholt wants to merge 1 commit intomicrosoft:mainfrom
basnijholt wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The pin was added in microsoft#1274 to work around a DLL import error (microsoft#1266). The root cause was an outdated msvc-runtime package, not an onnxruntime regression (microsoft/onnxruntime#24843). The pin blocks Python 3.14 support (microsoft#1470) since onnxruntime 1.24.1 (which adds 3.14 wheels) exceeds the upper bound. Fixes microsoft#1550
basnijholt
added a commit
to basnijholt/agent-cli
that referenced
this pull request
Feb 6, 2026
Force onnxruntime>=1.24.1 on non-Windows so the resolver picks a version with Python 3.14 wheels. On Windows, markitdown caps onnxruntime<=1.20.1 (microsoft/markitdown#1551), so keep the original lower bounds there. Skip rag/memory extras in CI on Python 3.14 because chromadb still uses pydantic v1 which is incompatible with 3.14.
basnijholt
added a commit
to basnijholt/agent-cli
that referenced
this pull request
Feb 6, 2026
markitdown caps onnxruntime<=1.20.1 on Windows which has no 3.14 wheels (microsoft/markitdown#1551)
basnijholt
added a commit
to basnijholt/agent-cli
that referenced
this pull request
Feb 6, 2026
markitdown caps onnxruntime<=1.20.1 on Windows which has no 3.14 wheels (microsoft/markitdown#1551)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onnxruntime<=1.20.1; sys_platform == 'win32'pin frompackages/markitdown/pyproject.tomlContext
The pin was added in #1274 to work around a DLL import error (#1266). The investigation in microsoft/onnxruntime#24843 showed:
msvc-runtimepackage (updating it fixed it)onnxruntime>=1.22.0has a genuine regression on thewindows-2019runner, butwindows-2022andwindows-2025work finewindows-2019is EOL and scheduled for deprecationThe pin now blocks Python 3.14 support (#1470, #1550) because
onnxruntime1.24.1 — which adds Python 3.14 wheels — exceeds the<=1.20.1upper bound. Theonnxruntimedependency comes frommagika, which itself doesn't have this pin.Fixes #1550