Drop Python <3.14 restriction (onnxruntime 1.24.1 supports it)#415
Open
basnijholt wants to merge 11 commits intomainfrom
Open
Drop Python <3.14 restriction (onnxruntime 1.24.1 supports it)#415basnijholt wants to merge 11 commits intomainfrom
basnijholt wants to merge 11 commits intomainfrom
Conversation
Remove the requires-python upper bound (<3.14) and all related workarounds that were in place because onnxruntime lacked Python 3.14 wheels: - pyproject.toml: remove <3.14 constraint - deps.py: remove Python 3.13 capping in uv tool install and uvx re-exec - deps.py: remove -p 3.13 from install hint messages - service_config.py: remove whisper service python_version='3.13' pin - CI: update test matrix from 3.13 to 3.14 - docs/README: remove all -p 3.13 flags and related notes - wyoming-mlx-whisper: remove <3.14 upper bound Note: tts-kokoro remains pinned to Python 3.12 (separate issue with curated-tokenizers lacking 3.13 wheels).
Bump onnxruntime lower bound to >=1.24.1 on non-Windows platforms to ensure the resolver picks a version with Python 3.14 wheels. On Windows, keep >=1.17.0/>=1.16.0 because markitdown pins onnxruntime<=1.20.1 (microsoft/markitdown#1266, PR #1465 pending to lift it).
Force onnxruntime>=1.24.1 on non-Windows so the resolver picks a version with Python 3.14 wheels. On Windows, markitdown caps onnxruntime<=1.20.1 (microsoft/markitdown#1551), so keep the original lower bounds there. Skip rag/memory extras in CI on Python 3.14 because chromadb still uses pydantic v1 which is incompatible with 3.14.
Remove platform-split onnxruntime pins — uv resolves the right version per platform via markitdown's transitive constraint anyway. Revert the CI workaround that skipped rag/memory on 3.14.
markitdown caps onnxruntime<=1.20.1 on Windows which has no 3.14 wheels (microsoft/markitdown#1551)
basnijholt
force-pushed
the
drop-python-3.13-restriction
branch
from
b608902 to
937c95f
Compare
Patch pydantic at runtime so chromadb's broken pydantic v1 usage works on 3.14. Remove once chromadb ships a fix (chroma-core/chroma#6356).
basnijholt
force-pushed
the
drop-python-3.13-restriction
branch
from
ec4dd94 to
6f868f5
Compare
First chromadb import can be slow on 3.14 due to the monkeypatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requires-python = ">=3.11,<3.14"upper bound frompyproject.tomlnow that onnxruntime 1.24.1 supports Python 3.14>=1.24.1on non-Windows to ensure the resolver picks a version with Python 3.14 wheels>=1.17.0/>=1.16.0on Windows becausemarkitdownpinsonnxruntime<=1.20.1there (upstream PR: Remove onnxruntime<=1.20.1 Windows pin microsoft/markitdown#1551)deps.py(uv tool install capping, uvx--python 3.13re-exec,-p 3.13in install hints)python_version="3.13"pin inservice_config.py["3.11", "3.13"]to["3.11", "3.14"]-p 3.13flags and related notes from docs, README, SKILL files, and plugin README<3.14upper bound fromwyoming-mlx-whisper/pyproject.tomlNote: tts-kokoro remains pinned to Python 3.12 (separate issue —
curated-tokenizersviakokoro→misaki→spacylacks 3.13 wheels).