Revert "Switch to using new errdefs repo" #2269
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yankay
force-pushed
the
revert-errdefs
branch
from
8fd2845 to
f6bb639
Compare
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
yankay
force-pushed
the
revert-errdefs
branch
from
f6bb639 to
1edb1bc
Compare
Author
|
HI @kevpar Would you please help to review it? |
Contributor
|
This should probably only be in the v0.11 branch, because hcsshim v0.12 will be used with containerd v2.0, which no longer has the package? cc @dmcgowan |
|
Closing since #2293 was already merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #2263 (comment), On containerd's side, it was a mistake to move to errdefs 0.1.0 in containerd 1.7 considering the package was not stable.
The containerd has revert the change by: containerd/containerd#10712 .
So both revert #2016 because it using the containerd 1.7
And Because containerd is using the hcsshim, the dependency of
errdefs 0.1.0make the containerd cannot compile witherrdefs 0.2.0.: containerd/containerd#10693.