[WIP]Update containerd/errdefs to v0.2.0 #2263
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yankay
force-pushed
the
update-errdefs-v0.2.0
branch
from
a0ea493 to
9edc08f
Compare
Author
|
@microsoft-github-policy-service agree company="DaoCloud" |
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
yankay
force-pushed
the
update-errdefs-v0.2.0
branch
from
9edc08f to
5d84f6b
Compare
yankay
changed the title
Contributor
|
Thanks for opening that up on the hcsshim side. On our side, I believe it was a mistake to move to errdefs 0.1.0 in containerd 1.7 considering the package was not stable. I opened #10712 to revert that change. We might need that change for hcsshim as well, I think its better to revert the change than introduce a breaking dependency in 1.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update containerd/errdefs to v0.2.0 . A complete list of changes can be found here: https://github.com/containerd/errdefs/releases/tag/v0.2.0 .
Because of the containerd/errdefs#5 , It needs to change golang file.
This will help with some of the circular dependencies across many projects. like: containerd/containerd#10693