Skip to content

Fix MigrateVector cluster tests for StackExchange.Redis 2.11.8 #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vazois merged 3 commits into from
Mar 3, 2026
Merged

Fix MigrateVector cluster tests for StackExchange.Redis 2.11.8 #1595

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db76211
Initial plan
Copilot Mar 3, 2026
adacac2
Fix MigrateVector tests to handle transient errors from StackExchange…
Copilot Mar 3, 2026
40e8c80
Fix MigrateVector tests: use Exception catch + specific MOVED message…
Copilot Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 52 additions & 19 deletions test/Garnet.test.cluster/VectorSets/ClusterVectorSetTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1362,20 +1362,27 @@ public async Task MigrateVectorSetWhileModifyingAsync()
await Task.Delay(1).ConfigureAwait(false);
}

// This should follow redirects, so migration shouldn't cause any failures
// This should follow redirects, so migration shouldn't cause any failures.
// StackExchange.Redis 2.11.8 changed MOVED handling: when MOVED points to the same endpoint,
// it reconnects before retrying, which can throw RedisConnectionException or RedisTimeoutException
// instead of (or in addition to) RedisServerException("MOVED ...").
try
{
var addRes = (int)readWriteDb.Execute("VADD", [new RedisKey(primary0Key), "XB8", data, elem, "XPREQ8", "SETATTR", attr]);
ClassicAssert.AreEqual(1, addRes);
}
catch (RedisServerException exc)
// Catch Exception (not RedisException) because RedisTimeoutException extends
// TimeoutException, not RedisException. Two MOVED message formats exist:
// - Server: "MOVED N host:port"
// - Client (SE.Redis 2.11.8+): "Key has MOVED to Endpoint X:port..."
catch (Exception exc) when (
exc is RedisTimeoutException
|| exc is RedisConnectionException
|| (exc is RedisServerException rse && (
rse.Message.StartsWith("MOVED ")
|| rse.Message.StartsWith("Key has MOVED to "))))
{
if (exc.Message.StartsWith("MOVED "))
{
continue;
}

throw;
continue;
}

added.Add((elem.ToArray(), data.ToArray(), attr.ToArray()));
Expand Down Expand Up @@ -1718,20 +1725,28 @@ public async Task MigrateVectorStressAsync()
ClassicAssert.AreEqual(1, addRes);
break;
}
catch (RedisServerException exc)
// Catch Exception (not RedisException) because RedisTimeoutException extends
// TimeoutException, not RedisException. Two MOVED message formats exist:
// - Server: "MOVED N host:port"
// - Client (SE.Redis 2.11.8+): "Key has MOVED to Endpoint X:port..."
catch (Exception exc) when (
exc is RedisTimeoutException
|| exc is RedisConnectionException
|| (exc is RedisServerException rse && (
rse.Message.StartsWith("MOVED ")
|| rse.Message.StartsWith("Key has MOVED to "))))
{
if (exc.Message.StartsWith("MOVED "))
// These are all retryable transient errors during slot migration:
// - RedisServerException("MOVED"): slot has moved, retry
// - RedisTimeoutException: server blocked in WaitForSlotToStabilize, timed out
// - RedisConnectionException: reconnect triggered by StackExchange.Redis 2.11.8+
// MOVED-to-same-endpoint handling
if (writeCancel.IsCancellationRequested)
{
// This is fine, just try again if we're not cancelled
if (writeCancel.IsCancellationRequested)
{
return;
}

continue;
return;
}

throw;
continue;
}
}

Expand Down Expand Up @@ -1784,7 +1799,25 @@ public async Task MigrateVectorStressAsync()

var (elem, data, _, _) = written.ToList()[readTaskRandom.Next(r)];

var emb = (string[])readWriteDB.Execute("VEMB", [new RedisKey(key), elem]);
string[] emb;
try
{
emb = (string[])readWriteDB.Execute("VEMB", [new RedisKey(key), elem]);
}
// Catch Exception (not RedisException) because RedisTimeoutException extends
// TimeoutException, not RedisException. Two MOVED message formats exist:
// - Server: "MOVED N host:port"
// - Client (SE.Redis 2.11.8+): "Key has MOVED to Endpoint X:port..."
catch (Exception exc) when (
exc is RedisTimeoutException
|| exc is RedisConnectionException
|| (exc is RedisServerException rse && (
rse.Message.StartsWith("MOVED ")
|| rse.Message.StartsWith("Key has MOVED to "))))
{
// Transient errors during slot migration are expected; retry
continue;
}

if (emb.Length == 0)
{
Expand Down