Fix MigrateVector cluster tests for StackExchange.Redis 2.11.8#1595
Merged
vazois merged 3 commits intodependabot/nuget/nuget-deps-4ed949ffaffrom Mar 3, 2026
Merged
Fix MigrateVector cluster tests for StackExchange.Redis 2.11.8#1595vazois merged 3 commits intodependabot/nuget/nuget-deps-4ed949ffaffrom
vazois merged 3 commits intodependabot/nuget/nuget-deps-4ed949ffaffrom
Conversation
….Redis 2.11.8 Co-authored-by: vazois <96085550+vazois@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Bump nuget-deps group with updates
Fix MigrateVector cluster tests for StackExchange.Redis 2.11.8 MOVED handling change
Mar 3, 2026
… patterns for SE.Redis 2.11.8 Co-authored-by: vazois <96085550+vazois@users.noreply.github.com>
Copilot
AI
changed the title
Fix MigrateVector cluster tests for StackExchange.Redis 2.11.8 MOVED handling change
Fix MigrateVector cluster tests for StackExchange.Redis 2.11.8
Mar 3, 2026
vazois
added a commit
that referenced
this pull request
Mar 4, 2026
* Bump the nuget-deps group with 14 updates Bumps diskann-garnet from 1.0.23 to 1.0.25 Bumps Microsoft.Extensions.Configuration.Binder from 10.0.2 to 10.0.3 Bumps Microsoft.Extensions.Configuration.Json from 10.0.2 to 10.0.3 Bumps Microsoft.Extensions.Logging from 10.0.2 to 10.0.3 Bumps Microsoft.Extensions.Logging.Configuration from 9.0.8 to 10.0.3 Bumps Microsoft.Extensions.Logging.Console from 9.0.8 to 10.0.3 Bumps Microsoft.IdentityModel.Protocols.OpenIdConnect from 8.6.1 to 8.16.0 Bumps Microsoft.IdentityModel.Validators from 8.6.1 to 8.16.0 Bumps Microsoft.NET.Test.Sdk from 18.0.1 to 18.3.0 Bumps NUnit from 4.1.0 to 4.5.0 Bumps NUnit3TestAdapter from 4.6.0 to 6.1.0 Bumps StackExchange.Redis from 2.9.25 to 2.11.8 Bumps System.IdentityModel.Tokens.Jwt from 8.6.1 to 8.16.0 Bumps System.Numerics.Tensors from 9.0.9 to 10.0.3 --- updated-dependencies: - dependency-name: diskann-garnet dependency-version: 1.0.25 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: Microsoft.Extensions.Configuration.Binder dependency-version: 10.0.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: Microsoft.Extensions.Configuration.Json dependency-version: 10.0.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: Microsoft.Extensions.Logging dependency-version: 10.0.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: Microsoft.Extensions.Logging.Configuration dependency-version: 10.0.3 dependency-type: direct:production update-type: version-update:semver-major dependency-group: nuget-deps - dependency-name: Microsoft.Extensions.Logging.Console dependency-version: 10.0.3 dependency-type: direct:production update-type: version-update:semver-major dependency-group: nuget-deps - dependency-name: Microsoft.IdentityModel.Protocols.OpenIdConnect dependency-version: 8.16.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: System.IdentityModel.Tokens.Jwt dependency-version: 8.16.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: Microsoft.IdentityModel.Validators dependency-version: 8.16.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: Microsoft.NET.Test.Sdk dependency-version: 18.3.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: NUnit dependency-version: 4.5.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: NUnit3TestAdapter dependency-version: 6.1.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: nuget-deps - dependency-name: StackExchange.Redis dependency-version: 2.11.8 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: System.Numerics.Tensors dependency-version: 10.0.3 dependency-type: direct:production update-type: version-update:semver-major dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * fix changes in API * revert unit test upgrade * Add ConfigureAwait(false) to all test await expressions to fix NUnit 4.5 deadlock (#1593) * Initial plan * Add .ConfigureAwait(false) to all await expressions in test files Add .ConfigureAwait(false) to every await expression across 38 test files under test/ to follow best practices for library/test code and avoid potential deadlocks in synchronization contexts. - Handles single-line and multi-line await expressions - Handles ternary await expressions (both branches) - Skips await foreach and await using (already correct) - Excludes Task.Yield() which returns YieldAwaitable (no ConfigureAwait support) - No changes outside test/ directory Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Vasileios Zois <96085550+vazois@users.noreply.github.com> * upgrade nunit * Fix MigrateVector cluster tests for StackExchange.Redis 2.11.8 (#1595) * Initial plan * Fix MigrateVector tests to handle transient errors from StackExchange.Redis 2.11.8 Co-authored-by: vazois <96085550+vazois@users.noreply.github.com> * Fix MigrateVector tests: use Exception catch + specific MOVED message patterns for SE.Redis 2.11.8 Co-authored-by: vazois <96085550+vazois@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: vazois <96085550+vazois@users.noreply.github.com> * revert diskann version --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vasileios Zois <vazois@microsoft.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Vasileios Zois <96085550+vazois@users.noreply.github.com> Co-authored-by: Tal Zaccai <talzacc@microsoft.com>
vazois
added a commit
that referenced
this pull request
Mar 4, 2026
* Bump the nuget-deps group with 14 updates Bumps diskann-garnet from 1.0.23 to 1.0.25 Bumps Microsoft.Extensions.Configuration.Binder from 10.0.2 to 10.0.3 Bumps Microsoft.Extensions.Configuration.Json from 10.0.2 to 10.0.3 Bumps Microsoft.Extensions.Logging from 10.0.2 to 10.0.3 Bumps Microsoft.Extensions.Logging.Configuration from 9.0.8 to 10.0.3 Bumps Microsoft.Extensions.Logging.Console from 9.0.8 to 10.0.3 Bumps Microsoft.IdentityModel.Protocols.OpenIdConnect from 8.6.1 to 8.16.0 Bumps Microsoft.IdentityModel.Validators from 8.6.1 to 8.16.0 Bumps Microsoft.NET.Test.Sdk from 18.0.1 to 18.3.0 Bumps NUnit from 4.1.0 to 4.5.0 Bumps NUnit3TestAdapter from 4.6.0 to 6.1.0 Bumps StackExchange.Redis from 2.9.25 to 2.11.8 Bumps System.IdentityModel.Tokens.Jwt from 8.6.1 to 8.16.0 Bumps System.Numerics.Tensors from 9.0.9 to 10.0.3 --- updated-dependencies: - dependency-name: diskann-garnet dependency-version: 1.0.25 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: Microsoft.Extensions.Configuration.Binder dependency-version: 10.0.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: Microsoft.Extensions.Configuration.Json dependency-version: 10.0.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: Microsoft.Extensions.Logging dependency-version: 10.0.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: Microsoft.Extensions.Logging.Configuration dependency-version: 10.0.3 dependency-type: direct:production update-type: version-update:semver-major dependency-group: nuget-deps - dependency-name: Microsoft.Extensions.Logging.Console dependency-version: 10.0.3 dependency-type: direct:production update-type: version-update:semver-major dependency-group: nuget-deps - dependency-name: Microsoft.IdentityModel.Protocols.OpenIdConnect dependency-version: 8.16.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: System.IdentityModel.Tokens.Jwt dependency-version: 8.16.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: Microsoft.IdentityModel.Validators dependency-version: 8.16.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: Microsoft.NET.Test.Sdk dependency-version: 18.3.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: NUnit dependency-version: 4.5.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: NUnit3TestAdapter dependency-version: 6.1.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: nuget-deps - dependency-name: StackExchange.Redis dependency-version: 2.11.8 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: System.Numerics.Tensors dependency-version: 10.0.3 dependency-type: direct:production update-type: version-update:semver-major dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * fix changes in API * revert unit test upgrade * Add ConfigureAwait(false) to all test await expressions to fix NUnit 4.5 deadlock (#1593) * Initial plan * Add .ConfigureAwait(false) to all await expressions in test files Add .ConfigureAwait(false) to every await expression across 38 test files under test/ to follow best practices for library/test code and avoid potential deadlocks in synchronization contexts. - Handles single-line and multi-line await expressions - Handles ternary await expressions (both branches) - Skips await foreach and await using (already correct) - Excludes Task.Yield() which returns YieldAwaitable (no ConfigureAwait support) - No changes outside test/ directory Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Vasileios Zois <96085550+vazois@users.noreply.github.com> * upgrade nunit * Fix MigrateVector cluster tests for StackExchange.Redis 2.11.8 (#1595) * Initial plan * Fix MigrateVector tests to handle transient errors from StackExchange.Redis 2.11.8 Co-authored-by: vazois <96085550+vazois@users.noreply.github.com> * Fix MigrateVector tests: use Exception catch + specific MOVED message patterns for SE.Redis 2.11.8 Co-authored-by: vazois <96085550+vazois@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: vazois <96085550+vazois@users.noreply.github.com> * revert diskann version --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vasileios Zois <vazois@microsoft.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Vasileios Zois <96085550+vazois@users.noreply.github.com> Co-authored-by: Tal Zaccai <talzacc@microsoft.com>
vazois
added a commit
that referenced
this pull request
Mar 4, 2026
* Bump the nuget-deps group with 14 updates Bumps diskann-garnet from 1.0.23 to 1.0.25 Bumps Microsoft.Extensions.Configuration.Binder from 10.0.2 to 10.0.3 Bumps Microsoft.Extensions.Configuration.Json from 10.0.2 to 10.0.3 Bumps Microsoft.Extensions.Logging from 10.0.2 to 10.0.3 Bumps Microsoft.Extensions.Logging.Configuration from 9.0.8 to 10.0.3 Bumps Microsoft.Extensions.Logging.Console from 9.0.8 to 10.0.3 Bumps Microsoft.IdentityModel.Protocols.OpenIdConnect from 8.6.1 to 8.16.0 Bumps Microsoft.IdentityModel.Validators from 8.6.1 to 8.16.0 Bumps Microsoft.NET.Test.Sdk from 18.0.1 to 18.3.0 Bumps NUnit from 4.1.0 to 4.5.0 Bumps NUnit3TestAdapter from 4.6.0 to 6.1.0 Bumps StackExchange.Redis from 2.9.25 to 2.11.8 Bumps System.IdentityModel.Tokens.Jwt from 8.6.1 to 8.16.0 Bumps System.Numerics.Tensors from 9.0.9 to 10.0.3 --- updated-dependencies: - dependency-name: diskann-garnet dependency-version: 1.0.25 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: Microsoft.Extensions.Configuration.Binder dependency-version: 10.0.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: Microsoft.Extensions.Configuration.Json dependency-version: 10.0.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: Microsoft.Extensions.Logging dependency-version: 10.0.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: Microsoft.Extensions.Logging.Configuration dependency-version: 10.0.3 dependency-type: direct:production update-type: version-update:semver-major dependency-group: nuget-deps - dependency-name: Microsoft.Extensions.Logging.Console dependency-version: 10.0.3 dependency-type: direct:production update-type: version-update:semver-major dependency-group: nuget-deps - dependency-name: Microsoft.IdentityModel.Protocols.OpenIdConnect dependency-version: 8.16.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: System.IdentityModel.Tokens.Jwt dependency-version: 8.16.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: Microsoft.IdentityModel.Validators dependency-version: 8.16.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: Microsoft.NET.Test.Sdk dependency-version: 18.3.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: NUnit dependency-version: 4.5.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: NUnit3TestAdapter dependency-version: 6.1.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: nuget-deps - dependency-name: StackExchange.Redis dependency-version: 2.11.8 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: System.Numerics.Tensors dependency-version: 10.0.3 dependency-type: direct:production update-type: version-update:semver-major dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * fix changes in API * revert unit test upgrade * Add ConfigureAwait(false) to all test await expressions to fix NUnit 4.5 deadlock (#1593) * Initial plan * Add .ConfigureAwait(false) to all await expressions in test files Add .ConfigureAwait(false) to every await expression across 38 test files under test/ to follow best practices for library/test code and avoid potential deadlocks in synchronization contexts. - Handles single-line and multi-line await expressions - Handles ternary await expressions (both branches) - Skips await foreach and await using (already correct) - Excludes Task.Yield() which returns YieldAwaitable (no ConfigureAwait support) - No changes outside test/ directory Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Vasileios Zois <96085550+vazois@users.noreply.github.com> * upgrade nunit * Fix MigrateVector cluster tests for StackExchange.Redis 2.11.8 (#1595) * Initial plan * Fix MigrateVector tests to handle transient errors from StackExchange.Redis 2.11.8 Co-authored-by: vazois <96085550+vazois@users.noreply.github.com> * Fix MigrateVector tests: use Exception catch + specific MOVED message patterns for SE.Redis 2.11.8 Co-authored-by: vazois <96085550+vazois@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: vazois <96085550+vazois@users.noreply.github.com> * revert diskann version --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vasileios Zois <vazois@microsoft.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Vasileios Zois <96085550+vazois@users.noreply.github.com> Co-authored-by: Tal Zaccai <talzacc@microsoft.com>
vazois
added a commit
that referenced
this pull request
Mar 4, 2026
…F operations (#1599) * SkipChecksum validation testing and fix * validate HLL format with skipRDBRestoreChecksumValidation * add tests that cover different length encoding * add full sparse stream validation * skipRDBRestoreChecksumValidation for slot validation tests * remove double validation and fix buffer swap * reduce test overhead * fix redirection tests for RESTORE * eliminate SkipRDBRestoreChecksumValidation option * Bump the nuget-deps group with 14 updates (#1592) * Bump the nuget-deps group with 14 updates Bumps diskann-garnet from 1.0.23 to 1.0.25 Bumps Microsoft.Extensions.Configuration.Binder from 10.0.2 to 10.0.3 Bumps Microsoft.Extensions.Configuration.Json from 10.0.2 to 10.0.3 Bumps Microsoft.Extensions.Logging from 10.0.2 to 10.0.3 Bumps Microsoft.Extensions.Logging.Configuration from 9.0.8 to 10.0.3 Bumps Microsoft.Extensions.Logging.Console from 9.0.8 to 10.0.3 Bumps Microsoft.IdentityModel.Protocols.OpenIdConnect from 8.6.1 to 8.16.0 Bumps Microsoft.IdentityModel.Validators from 8.6.1 to 8.16.0 Bumps Microsoft.NET.Test.Sdk from 18.0.1 to 18.3.0 Bumps NUnit from 4.1.0 to 4.5.0 Bumps NUnit3TestAdapter from 4.6.0 to 6.1.0 Bumps StackExchange.Redis from 2.9.25 to 2.11.8 Bumps System.IdentityModel.Tokens.Jwt from 8.6.1 to 8.16.0 Bumps System.Numerics.Tensors from 9.0.9 to 10.0.3 --- updated-dependencies: - dependency-name: diskann-garnet dependency-version: 1.0.25 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: Microsoft.Extensions.Configuration.Binder dependency-version: 10.0.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: Microsoft.Extensions.Configuration.Json dependency-version: 10.0.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: Microsoft.Extensions.Logging dependency-version: 10.0.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: Microsoft.Extensions.Logging.Configuration dependency-version: 10.0.3 dependency-type: direct:production update-type: version-update:semver-major dependency-group: nuget-deps - dependency-name: Microsoft.Extensions.Logging.Console dependency-version: 10.0.3 dependency-type: direct:production update-type: version-update:semver-major dependency-group: nuget-deps - dependency-name: Microsoft.IdentityModel.Protocols.OpenIdConnect dependency-version: 8.16.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: System.IdentityModel.Tokens.Jwt dependency-version: 8.16.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: Microsoft.IdentityModel.Validators dependency-version: 8.16.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: Microsoft.NET.Test.Sdk dependency-version: 18.3.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: NUnit dependency-version: 4.5.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: NUnit3TestAdapter dependency-version: 6.1.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: nuget-deps - dependency-name: StackExchange.Redis dependency-version: 2.11.8 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: System.Numerics.Tensors dependency-version: 10.0.3 dependency-type: direct:production update-type: version-update:semver-major dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * fix changes in API * revert unit test upgrade * Add ConfigureAwait(false) to all test await expressions to fix NUnit 4.5 deadlock (#1593) * Initial plan * Add .ConfigureAwait(false) to all await expressions in test files Add .ConfigureAwait(false) to every await expression across 38 test files under test/ to follow best practices for library/test code and avoid potential deadlocks in synchronization contexts. - Handles single-line and multi-line await expressions - Handles ternary await expressions (both branches) - Skips await foreach and await using (already correct) - Excludes Task.Yield() which returns YieldAwaitable (no ConfigureAwait support) - No changes outside test/ directory Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Vasileios Zois <96085550+vazois@users.noreply.github.com> * upgrade nunit * Fix MigrateVector cluster tests for StackExchange.Redis 2.11.8 (#1595) * Initial plan * Fix MigrateVector tests to handle transient errors from StackExchange.Redis 2.11.8 Co-authored-by: vazois <96085550+vazois@users.noreply.github.com> * Fix MigrateVector tests: use Exception catch + specific MOVED message patterns for SE.Redis 2.11.8 Co-authored-by: vazois <96085550+vazois@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: vazois <96085550+vazois@users.noreply.github.com> * revert diskann version --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vasileios Zois <vazois@microsoft.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Vasileios Zois <96085550+vazois@users.noreply.github.com> Co-authored-by: Tal Zaccai <talzacc@microsoft.com> * cleanup unused properties * add more comments at HLL validation * add test that bypasses crc check by faking it while corrupting the HLL payload --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Tal Zaccai <talzacc@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MigrateVectorSetWhileModifyingAsyncandMigrateVectorStressAsyncbroke after upgrading StackExchange.Redis from 2.9.25 to 2.11.8 due to two behavioral changes in how MOVED errors surface to the application.Root causes
1.
RedisTimeoutExceptionis not aRedisExceptionIt extends
System.TimeoutException. The originalcatch (RedisException exc) when (exc is RedisTimeoutException ...)was always false and caused CS0184 build errors.2. SE.Redis 2.11.8 emits a different MOVED message format
In cluster mode with
CommandFlags.NoRedirect, MOVED responses are now surfaced as:The original handler checked
StartsWith("MOVED ")— which only matches the raw protocol message — and missed this client-level format, causing the write task to fault.Changes
catch (RedisException)→catch (Exception) when (...)— required sinceRedisTimeoutException : TimeoutException, notRedisExceptionStartsWith("MOVED ")— raw server-level Redis protocol responseStartsWith("Key has MOVED to ")— SE.Redis 2.11.8+ client-level redirect messageMigrateVectorStressAsync— apply the same transient-error handling to reads, which were previously unprotected during slot migration💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.