-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to ts 5.2.2 #32859
base: master
Are you sure you want to change the base?
chore: migrate to ts 5.2.2 #32859
Conversation
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
🕵 FluentUIV0 No visual regressions between this PR and main |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 643 | 630 | 5000 | |
Button | mount | 304 | 311 | 5000 | |
Field | mount | 1145 | 1111 | 5000 | |
FluentProvider | mount | 702 | 708 | 5000 | |
FluentProviderWithTheme | mount | 84 | 87 | 10 | |
FluentProviderWithTheme | virtual-rerender | 32 | 33 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 79 | 70 | 10 | |
MakeStyles | mount | 858 | 848 | 50000 | |
Persona | mount | 1765 | 1701 | 5000 | |
SpinButton | mount | 1387 | 1348 | 5000 | |
SwatchPicker | mount | 1665 | 1635 | 5000 |
📊 Bundle size reportUnchanged fixtures
|
@@ -337,7 +337,7 @@ | |||
"tsconfig-paths": "4.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
Avatar Converged.badgeMask.chromium.png | 12 | Changed |
Drawer 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
Drawer.Full Overlay High Contrast.chromium.png | 2113 | Changed |
Perf Analysis (
|
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
TreeWith60ListItems.default | 94 | 81 | 1.16:1 |
ChatWithPopoverPerf.default | 220 | 193 | 1.14:1 |
AccordionMinimalPerf.default | 78 | 71 | 1.1:1 |
GridMinimalPerf.default | 198 | 182 | 1.09:1 |
ReactionMinimalPerf.default | 225 | 206 | 1.09:1 |
ImageMinimalPerf.default | 240 | 223 | 1.08:1 |
ListMinimalPerf.default | 328 | 303 | 1.08:1 |
PortalMinimalPerf.default | 90 | 83 | 1.08:1 |
ProviderMinimalPerf.default | 218 | 202 | 1.08:1 |
TextMinimalPerf.default | 202 | 187 | 1.08:1 |
StatusMinimalPerf.default | 412 | 390 | 1.06:1 |
ButtonMinimalPerf.default | 92 | 88 | 1.05:1 |
BoxMinimalPerf.default | 200 | 193 | 1.04:1 |
ButtonOverridesMissPerf.default | 657 | 636 | 1.03:1 |
DropdownManyItemsPerf.default | 402 | 392 | 1.03:1 |
InputMinimalPerf.default | 551 | 534 | 1.03:1 |
ListNestedPerf.default | 325 | 317 | 1.03:1 |
LoaderMinimalPerf.default | 191 | 186 | 1.03:1 |
TableManyItemsPerf.default | 1118 | 1089 | 1.03:1 |
ToolbarMinimalPerf.default | 534 | 519 | 1.03:1 |
AlertMinimalPerf.default | 161 | 158 | 1.02:1 |
AvatarMinimalPerf.default | 115 | 113 | 1.02:1 |
CarouselMinimalPerf.default | 258 | 252 | 1.02:1 |
DatepickerMinimalPerf.default | 3557 | 3501 | 1.02:1 |
SliderMinimalPerf.default | 735 | 724 | 1.02:1 |
TableMinimalPerf.default | 246 | 242 | 1.02:1 |
CustomToolbarPrototype.default | 1492 | 1458 | 1.02:1 |
AnimationMinimalPerf.default | 310 | 307 | 1.01:1 |
AttachmentMinimalPerf.default | 85 | 84 | 1.01:1 |
AttachmentSlotsPerf.default | 661 | 654 | 1.01:1 |
ChatDuplicateMessagesPerf.default | 155 | 154 | 1.01:1 |
ChatMinimalPerf.default | 434 | 429 | 1.01:1 |
RadioGroupMinimalPerf.default | 268 | 265 | 1.01:1 |
SkeletonMinimalPerf.default | 199 | 198 | 1.01:1 |
TooltipMinimalPerf.default | 1283 | 1274 | 1.01:1 |
EmbedMinimalPerf.default | 1858 | 1853 | 1:1 |
HeaderMinimalPerf.default | 209 | 210 | 1:1 |
PopupMinimalPerf.default | 348 | 347 | 1:1 |
RefMinimalPerf.default | 110 | 110 | 1:1 |
TextAreaMinimalPerf.default | 283 | 282 | 1:1 |
DividerMinimalPerf.default | 197 | 199 | 0.99:1 |
HeaderSlotsPerf.default | 458 | 461 | 0.99:1 |
ItemLayoutMinimalPerf.default | 705 | 709 | 0.99:1 |
MenuMinimalPerf.default | 505 | 511 | 0.99:1 |
SplitButtonMinimalPerf.default | 2272 | 2284 | 0.99:1 |
IconMinimalPerf.default | 393 | 396 | 0.99:1 |
CheckboxMinimalPerf.default | 1134 | 1162 | 0.98:1 |
LabelMinimalPerf.default | 215 | 220 | 0.98:1 |
LayoutMinimalPerf.default | 196 | 199 | 0.98:1 |
MenuButtonMinimalPerf.default | 937 | 952 | 0.98:1 |
CardMinimalPerf.default | 297 | 305 | 0.97:1 |
DropdownMinimalPerf.default | 1398 | 1436 | 0.97:1 |
ListCommonPerf.default | 391 | 402 | 0.97:1 |
SegmentMinimalPerf.default | 201 | 208 | 0.97:1 |
DialogMinimalPerf.default | 440 | 458 | 0.96:1 |
FormMinimalPerf.default | 220 | 230 | 0.96:1 |
RosterPerf.default | 1546 | 1603 | 0.96:1 |
ProviderMergeThemesPerf.default | 635 | 660 | 0.96:1 |
TreeMinimalPerf.default | 494 | 513 | 0.96:1 |
ListWith60ListItems.default | 344 | 362 | 0.95:1 |
VideoMinimalPerf.default | 437 | 467 | 0.94:1 |
FlexMinimalPerf.default | 156 | 171 | 0.91:1 |
ButtonSlotsPerf.default | 290 | 329 | 0.88:1 |
0de3441
to
ce11185
Compare
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 628 | 646 | 5000 | |
Breadcrumb | mount | 1692 | 1711 | 1000 | |
Checkbox | mount | 1709 | 1734 | 5000 | |
CheckboxBase | mount | 1481 | 1487 | 5000 | |
ChoiceGroup | mount | 2994 | 2954 | 5000 | |
ComboBox | mount | 694 | 685 | 1000 | |
CommandBar | mount | 6529 | 6630 | 1000 | |
ContextualMenu | mount | 13921 | 13232 | 1000 | |
DefaultButton | mount | 800 | 815 | 5000 | |
DetailsRow | mount | 2267 | 2252 | 5000 | |
DetailsRowFast | mount | 2252 | 2212 | 5000 | |
DetailsRowNoStyles | mount | 2046 | 2055 | 5000 | |
Dialog | mount | 2865 | 2876 | 1000 | |
DocumentCardTitle | mount | 239 | 233 | 1000 | |
Dropdown | mount | 1995 | 1997 | 5000 | |
FocusTrapZone | mount | 1151 | 1124 | 5000 | |
FocusZone | mount | 1091 | 1105 | 5000 | |
GroupedList | mount | 42916 | 42456 | 2 | |
GroupedList | virtual-rerender | 20468 | 20431 | 2 | |
GroupedList | virtual-rerender-with-unmount | 52217 | 52267 | 2 | |
GroupedListV2 | mount | 224 | 233 | 2 | |
GroupedListV2 | virtual-rerender | 224 | 218 | 2 | |
GroupedListV2 | virtual-rerender-with-unmount | 234 | 242 | 2 | |
IconButton | mount | 1161 | 1138 | 5000 | |
Label | mount | 345 | 339 | 5000 | |
Layer | mount | 2712 | 2792 | 5000 | |
Link | mount | 408 | 395 | 5000 | |
MenuButton | mount | 984 | 984 | 5000 | |
MessageBar | mount | 21271 | 21301 | 5000 | |
Nav | mount | 2053 | 2058 | 1000 | |
OverflowSet | mount | 815 | 818 | 5000 | |
Panel | mount | 1856 | 1859 | 1000 | |
Persona | mount | 759 | 751 | 1000 | |
Pivot | mount | 880 | 937 | 1000 | |
PrimaryButton | mount | 978 | 937 | 5000 | |
Rating | mount | 4740 | 4740 | 5000 | |
SearchBox | mount | 903 | 947 | 5000 | |
Shimmer | mount | 1897 | 1906 | 5000 | |
Slider | mount | 1356 | 1331 | 5000 | |
SpinButton | mount | 2940 | 2953 | 5000 | |
Spinner | mount | 403 | 397 | 5000 | |
SplitButton | mount | 1892 | 1885 | 5000 | |
Stack | mount | 429 | 428 | 5000 | |
StackWithIntrinsicChildren | mount | 902 | 889 | 5000 | |
StackWithTextChildren | mount | 2839 | 2853 | 5000 | |
SwatchColorPicker | mount | 6442 | 6345 | 5000 | |
TagPicker | mount | 1505 | 1501 | 5000 | |
Text | mount | 401 | 401 | 5000 | |
TextField | mount | 947 | 948 | 5000 | |
ThemeProvider | mount | 868 | 846 | 5000 | |
ThemeProvider | virtual-rerender | 599 | 594 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1324 | 1274 | 5000 | |
Toggle | mount | 630 | 616 | 5000 | |
buttonNative | mount | 189 | 195 | 5000 |
e8f410a
to
877529c
Compare
@@ -2615,3 +2615,51 @@ export const curveEasyEase = 'var(--curveEasyEase)'; | |||
* @public | |||
*/ | |||
export const curveLinear = 'var(--curveLinear)'; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got updated after #32356
5b938cd
to
07f2011
Compare
@@ -4,6 +4,7 @@ | |||
"jsx": "react", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual regressions to review in the fluentuiv8 Visual Regression Report
react-charting-AreaChart 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
react-charting-AreaChart.Custom Accessibility.chromium.png | 11 | Changed |
react-charting-VerticalBarChart 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
react-charting-VerticalBarChart.Basic - Secondary Y Axis.chromium.png | 4 | Changed |
07f2011
to
a4652bb
Compare
@@ -3,6 +3,7 @@ | |||
"compilerOptions": { | |||
"isolatedModules": false, | |||
"types": ["node", "cypress", "cypress-real-events"], | |||
"typeRoots": ["../../../node_modules", "../../../node_modules/@types"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without explicit typeRoots to node_modules cannot find types for cypress and cypress-real-events
@@ -3,8 +3,8 @@ | |||
"noEmit": true, | |||
"allowJs": true, | |||
"checkJs": true, | |||
"module": "commonjs", | |||
"moduleResolution": "nodenext", | |||
"module": "NodeNext", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a4652bb
to
597fc44
Compare
I don't think we want to set |
Release notes:
What's addressed:
Previous Behavior
New Behavior
Related Issue(s)