chore(web-components): remove redundant ts suppressions

microsoft · Sep 18, 2024 · 0de3441 · 0de3441
1 parent 9622e53
commit 0de3441
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 13 deletions.
diff --git a/packages/web-components/src/menu-item/menu-item.template.ts b/packages/web-components/src/menu-item/menu-item.template.ts
@@ -18,9 +18,7 @@ export function menuItemTemplate<T extends MenuItem>(options: MenuItemOptions =
       @click="${(x, c) => x.handleMenuItemClick(c.event as MouseEvent)}"
       @mouseover="${(x, c) => x.handleMouseOver(c.event as MouseEvent)}"
       @mouseout="${(x, c) => x.handleMouseOut(c.event as MouseEvent)}"
-      @toggle="${(x, c) =>
-        // @ts-expect-error - Baseline 2024
-        x.toggleHandler(c.event as ToggleEvent)}"
+      @toggle="${(x, c) => x.toggleHandler(c.event as ToggleEvent)}"
     >
       <slot name="indicator"> ${staticallyCompose(options.indicator)} </slot>
       ${startSlotTemplate(options)}

diff --git a/packages/web-components/src/menu-item/menu-item.ts b/packages/web-components/src/menu-item/menu-item.ts
@@ -183,7 +183,6 @@ export class MenuItem extends FASTElement {
       case keyArrowRight:
         //open/focus on submenu
         if (!this.disabled) {
-          // @ts-expect-error - Baseline 2024
           this.submenu?.togglePopover(true);
           this.submenu?.focus();
         }
@@ -193,7 +192,6 @@ export class MenuItem extends FASTElement {
       case keyArrowLeft:
         //close submenu
         if (this.parentElement?.hasAttribute('popover')) {
-          // @ts-expect-error - Baseline 2024
           this.parentElement.togglePopover(false);
           // focus the menu item containing the submenu
           this.parentElement.parentElement?.focus();
@@ -224,7 +222,6 @@ export class MenuItem extends FASTElement {
     if (this.disabled) {
       return false;
     }
-    // @ts-expect-error - Baseline 2024
     this.submenu?.togglePopover(true);
     return false;
   };
@@ -236,7 +233,6 @@ export class MenuItem extends FASTElement {
     if (this.contains(document.activeElement)) {
       return false;
     }
-    // @ts-expect-error - Baseline 2024
     this.submenu?.togglePopover(false);
 
     return false;
@@ -247,13 +243,11 @@ export class MenuItem extends FASTElement {
    * @internal
    */
   public toggleHandler = (e: Event): void => {
-    // @ts-expect-error - Baseline 2024
     if (e instanceof ToggleEvent && e.newState === 'open') {
       this.setAttribute('tabindex', '-1');
       this.elementInternals.ariaExpanded = 'true';
       this.setSubmenuPosition();
     }
-    // @ts-expect-error - Baseline 2024
     if (e instanceof ToggleEvent && e.newState === 'closed') {
       this.elementInternals.ariaExpanded = 'false';
       this.setAttribute('tabindex', '0');
@@ -275,7 +269,6 @@ export class MenuItem extends FASTElement {
 
       case MenuItemRole.menuitem:
         if (!!this.submenu) {
-          // @ts-expect-error - Baseline 2024
           this.submenu.togglePopover(true);
           this.submenu.focus();
           break;

diff --git a/packages/web-components/src/menu/menu.ts b/packages/web-components/src/menu/menu.ts
@@ -145,7 +145,6 @@ export class Menu extends FASTElement {
    * @public
    */
   public toggleMenu = () => {
-    // @ts-expect-error - Baseline 2024
     this._menuList?.togglePopover(!this._open);
   };
 
@@ -162,7 +161,6 @@ export class Menu extends FASTElement {
     ) {
       return;
     }
-    // @ts-expect-error - Baseline 2024
     this._menuList?.togglePopover(false);
 
     if (this.closeOnScroll) {
@@ -175,7 +173,6 @@ export class Menu extends FASTElement {
    * @public
    */
   public openMenu = (e?: Event) => {
-    // @ts-expect-error - Baseline 2024
     this._menuList?.togglePopover(true);
 
     if (e && this.openOnContext) {