Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-rules): implement no-missing-jsx-pragma in order to automate and unify slot API usage #32842

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

feat(eslint-rules): implement no-missing-jsx-pragma in order to automate and unify slot API usage #32842

wants to merge 6 commits into from

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Sep 16, 2024

Previous Behavior

New Behavior

Related Issue(s)

  • Fixes #

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 16, 2024 •
edited
Loading

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 16, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme mount 74 89 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 637 637 5000
Button mount 312 299 5000
Field mount 1125 1128 5000
FluentProvider mount 717 708 5000
FluentProviderWithTheme mount 74 89 10 Possible regression
FluentProviderWithTheme virtual-rerender 38 35 10
FluentProviderWithTheme virtual-rerender-with-unmount 83 76 10
MakeStyles mount 856 868 50000
Persona mount 1778 1779 5000
SpinButton mount 1421 1383 5000
SwatchPicker mount 1694 1707 5000

fabricteam
fabricteam reviewed Sep 16, 2024
View reviewed changes
change/@fluentui-react-jsx-runtime-5bfd81c5-626e-4d33-a616-fe50df609366.json Outdated
@@ -0,0 +1,7 @@
{
Copy link
Collaborator

@fabricteam fabricteam Sep 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv8 Visual Regression Report

react-charting-AreaChart 1 screenshots
Image Name Diff(in Pixels) Image Type
react-charting-AreaChart.Custom Accessibility.chromium.png 11 Changed
react-charting-LineChart 1 screenshots
Image Name Diff(in Pixels) Image Type
react-charting-LineChart.Gaps.chromium.png 1 Changed

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 16, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 16, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

fabricteam
fabricteam reviewed Sep 16, 2024
View reviewed changes
change/@fluentui-react-jsx-runtime-5bfd81c5-626e-4d33-a616-fe50df609366.json Outdated
@@ -0,0 +1,7 @@
{
Copy link
Collaborator

@fabricteam fabricteam Sep 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv9 Visual Regression Report

Avatar Converged 2 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.Badge Mask RTL.chromium.png 2 Changed
Avatar Converged.badgeMask.chromium.png 5 Changed
Drawer 3 screenshots
Image Name Diff(in Pixels) Image Type
Drawer.overlay drawer full.chromium.png 1161 Changed
Drawer.Full Overlay Dark Mode.chromium.png 991 Changed
Drawer.Full Overlay High Contrast.chromium.png 4905 Changed

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 16, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 97 86 1.13:1
ChatDuplicateMessagesPerf.default 154 142 1.08:1
DropdownManyItemsPerf.default 402 376 1.07:1
LayoutMinimalPerf.default 210 196 1.07:1
SegmentMinimalPerf.default 204 191 1.07:1
AccordionMinimalPerf.default 88 83 1.06:1
ButtonSlotsPerf.default 344 325 1.06:1
DialogMinimalPerf.default 454 429 1.06:1
SkeletonMinimalPerf.default 206 196 1.05:1
AvatarMinimalPerf.default 114 110 1.04:1
DropdownMinimalPerf.default 1450 1400 1.04:1
LoaderMinimalPerf.default 198 191 1.04:1
AlertMinimalPerf.default 167 162 1.03:1
BoxMinimalPerf.default 194 189 1.03:1
CardMinimalPerf.default 319 310 1.03:1
GridMinimalPerf.default 198 193 1.03:1
TreeMinimalPerf.default 487 471 1.03:1
TreeWith60ListItems.default 89 86 1.03:1
ButtonOverridesMissPerf.default 665 650 1.02:1
ChatMinimalPerf.default 446 439 1.02:1
ChatWithPopoverPerf.default 203 199 1.02:1
ImageMinimalPerf.default 215 211 1.02:1
ItemLayoutMinimalPerf.default 716 701 1.02:1
ListNestedPerf.default 314 309 1.02:1
ProviderMergeThemesPerf.default 643 629 1.02:1
RadioGroupMinimalPerf.default 265 259 1.02:1
ReactionMinimalPerf.default 211 207 1.02:1
TextMinimalPerf.default 203 199 1.02:1
TextAreaMinimalPerf.default 301 294 1.02:1
AnimationMinimalPerf.default 307 304 1.01:1
EmbedMinimalPerf.default 1893 1871 1.01:1
HeaderSlotsPerf.default 464 460 1.01:1
MenuMinimalPerf.default 506 503 1.01:1
PopupMinimalPerf.default 350 346 1.01:1
ProviderMinimalPerf.default 203 201 1.01:1
IconMinimalPerf.default 389 385 1.01:1
TableMinimalPerf.default 239 236 1.01:1
AttachmentMinimalPerf.default 90 90 1:1
DividerMinimalPerf.default 206 206 1:1
FlexMinimalPerf.default 157 157 1:1
InputMinimalPerf.default 529 530 1:1
RefMinimalPerf.default 111 111 1:1
TableManyItemsPerf.default 1093 1090 1:1
CustomToolbarPrototype.default 1447 1449 1:1
ToolbarMinimalPerf.default 529 528 1:1
TooltipMinimalPerf.default 1245 1248 1:1
AttachmentSlotsPerf.default 635 640 0.99:1
CarouselMinimalPerf.default 256 259 0.99:1
DatepickerMinimalPerf.default 3524 3556 0.99:1
ListMinimalPerf.default 302 306 0.99:1
MenuButtonMinimalPerf.default 947 952 0.99:1
SplitButtonMinimalPerf.default 2239 2258 0.99:1
CheckboxMinimalPerf.default 1122 1144 0.98:1
LabelMinimalPerf.default 223 228 0.98:1
RosterPerf.default 1588 1615 0.98:1
SliderMinimalPerf.default 720 736 0.98:1
StatusMinimalPerf.default 384 391 0.98:1
HeaderMinimalPerf.default 209 215 0.97:1
PortalMinimalPerf.default 84 87 0.97:1
FormMinimalPerf.default 203 213 0.95:1
VideoMinimalPerf.default 418 441 0.95:1
ListWith60ListItems.default 358 380 0.94:1
ListCommonPerf.default 377 410 0.92:1

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 16, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 638 632 5000
Breadcrumb mount 1710 1690 1000
Checkbox mount 1690 1781 5000
CheckboxBase mount 1504 1491 5000
ChoiceGroup mount 3068 3003 5000
ComboBox mount 686 677 1000
CommandBar mount 6587 6569 1000
ContextualMenu mount 12456 12500 1000
DefaultButton mount 792 810 5000
DetailsRow mount 2228 2222 5000
DetailsRowFast mount 2216 2237 5000
DetailsRowNoStyles mount 2007 2095 5000
Dialog mount 2691 2730 1000
DocumentCardTitle mount 232 230 1000
Dropdown mount 2036 1995 5000
FocusTrapZone mount 1180 1134 5000
FocusZone mount 1083 1101 5000
GroupedList mount 42181 42831 2
GroupedList virtual-rerender 20381 20350 2
GroupedList virtual-rerender-with-unmount 52340 52440 2
GroupedListV2 mount 228 227 2
GroupedListV2 virtual-rerender 223 219 2
GroupedListV2 virtual-rerender-with-unmount 228 238 2
IconButton mount 1145 1135 5000
Label mount 339 341 5000
Layer mount 2758 2696 5000
Link mount 402 398 5000
MenuButton mount 970 1020 5000
MessageBar mount 21513 21500 5000
Nav mount 2031 2039 1000
OverflowSet mount 797 800 5000
Panel mount 1860 1805 1000
Persona mount 760 765 1000
Pivot mount 890 916 1000
PrimaryButton mount 928 936 5000
Rating mount 4793 4771 5000
SearchBox mount 930 909 5000
Shimmer mount 1918 1904 5000
Slider mount 1373 1346 5000
SpinButton mount 3027 3000 5000
Spinner mount 386 387 5000
SplitButton mount 1903 1947 5000
Stack mount 440 425 5000
StackWithIntrinsicChildren mount 881 884 5000
StackWithTextChildren mount 2826 2793 5000
SwatchColorPicker mount 6427 6466 5000
TagPicker mount 1462 1465 5000
Text mount 386 388 5000
TextField mount 975 971 5000
ThemeProvider mount 853 872 5000
ThemeProvider virtual-rerender 585 589 5000
ThemeProvider virtual-rerender-with-unmount 1323 1307 5000
Toggle mount 620 636 5000
buttonNative mount 196 195 5000

@Hotell Hotell changed the title Workspace/eslint rules/jsx pragma feat(eslint-rules): implement no-missing-jsx-pragma in order to automate and unify slot API usage Sep 17, 2024
@Hotell Hotell force-pushed the workspace/eslint-rules/jsx-pragma branch from cd0514c to 3bfd369 Compare September 24, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@mltejera mltejera Awaiting requested review from mltejera mltejera will be requested when the pull request is marked ready for review mltejera is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Area: Linting Fluent UI react-components (v9) NX: workspace eslint-rules
Projects
None yet
Milestone
September Project Cycle Q3 2024
Development

Successfully merging this pull request may close these issues.
2 participants
@Hotell @fabricteam