Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(workspace-plugin): implement build executor #32439

Merged
merged 13 commits into from
Sep 24, 2024
Merged

feat(workspace-plugin): implement build executor #32439

merged 13 commits into from
Sep 24, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Sep 2, 2024 •
edited
Loading

Previous Behavior

New Behavior

💡 What is nx executor ? https://nx.dev/concepts/executors-and-configurations

  • implements build executor
  • replacement for npm script alias build which uses just-scripts (build:react-components)
  • NOTE:
    • executor implementation fixes inconsistencies with generating source maps that are present within our just-scripts logic
    • this first implementation wont emit .d.ts nor rolluped .d.ts - this is handled by generate-api executor but for sake of encapsulation we will invoke generate-api executor within this executor ( executor composition ) as a follow-up.

Related Issue(s)

@Hotell Hotell mentioned this pull request Sep 2, 2024
Closed
39 tasks
@fabricteam
Copy link
Collaborator

fabricteam commented Sep 2, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@Hotell Hotell force-pushed the nx/workspace-plugin/build-executor branch from c886f12 to 0d40dcd Compare September 6, 2024 12:36
@Hotell
Copy link
Contributor Author

Hotell commented Sep 10, 2024

/azp run

@Hotell Hotell marked this pull request as ready for review September 10, 2024 12:02
@Hotell Hotell requested a review from a team as a code owner September 10, 2024 12:02
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@Hotell
feat(workspace-plugin): implement build executor
c6fce24
@Hotell
test(workpsace-plugin): add e2e test coverage for build executor
7810c74
@Hotell
feat(workspace-plugin): reshuflle execution order from clean,assets,s…
543f3bf 
…wc to clean,swc,assets
@Hotell
feat(workspace-plugin): improve build executor schema
c4d7c76
@Hotell
test: update jest-config in order to resolve faulty @swc/types package
8fa0359
@Hotell
refactor: move logic to /lib
98af680
@Hotell
fix: make sure to process commonjs files with babel
ceda52b
@Hotell
fix: stop adding sourceMappingURL within babel to be consistent with …
39caa92 
…swc (bug in our flow) behavior
@Hotell
refactor: dont throw if project hasn't specified es6 output but conta…
b27a3cb 
…ins griffel styles
@Hotell
fix: use swcrc configs to provide transpile output as expected
38e1f4c
@Hotell
fix: jest setup
d4375cc
@Hotell
feat: add measure hooks
3c913ab
@Hotell Hotell force-pushed the nx/workspace-plugin/build-executor branch from 99afc31 to 3c913ab Compare September 11, 2024 13:19
@Hotell Hotell merged commit 20bfbad into microsoft:master Sep 24, 2024
20 checks passed
@Hotell Hotell deleted the nx/workspace-plugin/build-executor branch September 24, 2024 08:55
Hotell added a commit to Hotell/fluentui that referenced this pull request Sep 24, 2024
@Hotell
feat(workspace-plugin): implement build executor (microsoft#32439)
5dcdf45
@Hotell Hotell mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsunderhus bsunderhus bsunderhus left review comments

@mainframev mainframev mainframev approved these changes

Assignees
No one assigned
Labels
NX: workspace executors
Projects
None yet
Milestone
September Project Cycle Q3 2024
Development

Successfully merging this pull request may close these issues.
4 participants
@Hotell @fabricteam @bsunderhus @mainframev