Skip to content

[Switch] Font truncated a11y issue fix #2644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2023
Merged

[Switch] Font truncated a11y issue fix #2644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd575a3
fix switch font ally
rohanprasadofficial Feb 21, 2023
edc357d
Change files
rohanprasadofficial Feb 21, 2023
c8a1c7b
update snap
rohanprasadofficial Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-native-switch-c6e6f1fe-042e-4368-88e9-09d358647280.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix switch font ally",
"packageName": "@fluentui-react-native/switch",
"email": "rohanpd.work@gmail.com",
"dependentChangeType": "patch"
}
3 changes: 3 additions & 0 deletions packages/experimental/Switch/src/Switch.styling.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ export const switchStates: (keyof SwitchTokens)[] = [
'disabled',
];

const isMobile = Platform.OS === 'android' || Platform.OS === 'ios';

export const stylingSettings: UseStylingOptions<SwitchProps, SwitchSlotProps, SwitchTokens> = {
tokens: [defaultSwitchTokens, switchName],
states: switchStates,
Expand Down Expand Up @@ -103,6 +105,7 @@ export const stylingSettings: UseStylingOptions<SwitchProps, SwitchSlotProps, Sw
(tokens: SwitchTokens, theme: Theme) => ({
style: {
color: tokens.color,
...(isMobile && { flexShrink: 1 }),
...fontStyles.from(tokens, theme),
},
}),
Expand Down
2 changes: 2 additions & 0 deletions packages/experimental/Switch/src/__tests__/__snapshots__/Switch.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ exports[`Switch Default 1`] = `
style={
Object {
"color": "#242424",
"flexShrink": 1,
"fontFamily": "Segoe UI",
"fontSize": 13,
"fontWeight": "400",
Expand Down Expand Up @@ -177,6 +178,7 @@ exports[`Switch Disabled 1`] = `
style={
Object {
"color": "#e0e0e0",
"flexShrink": 1,
"fontFamily": "Segoe UI",
"fontSize": 13,
"fontWeight": "400",
Expand Down