Skip to content

[Switch] Font truncated a11y issue fix #2644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rohanprasadofficial
Copy link
Contributor

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

On font size increase the label text was getting truncated.
In this examples the fourth example disabled default unchecked switch. "FalseTest" was getting hidden inside screen.

Verification

Visual Verification after font size increase.

Before After
MicrosoftTeams-image (26) MicrosoftTeams-image (25)

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

@rohanprasadofficial rohanprasadofficial marked this pull request as ready for review February 21, 2023 12:01
@rohanprasadofficial rohanprasadofficial requested a review from a team as a code owner February 21, 2023 12:01
@rohanprasadofficial rohanprasadofficial added Area : Switch Switch , Toogle Area: Accessibility AutoMerge 🔁 Automatically merge when PR requirements met labels Feb 21, 2023
Copy link
Contributor

@ankraj12 ankraj12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check the guidance from PM/ design if this is coded as a component behaviour.

@rohanprasadofficial
Copy link
Contributor Author

We should check the guidance from PM/ design if this is coded as a component behaviour.

@ankraj12 , We had PM confirmation for label to be shown as all spanning across lines and not trucating it and this PR complies the same.

@rohanprasadofficial rohanprasadofficial merged commit 1ef73de into microsoft:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Accessibility Area : Switch Switch , Toogle AutoMerge 🔁 Automatically merge when PR requirements met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants