Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination Fix #4613

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Pagination Fix #4613

merged 3 commits into from
Sep 16, 2024

Conversation

LTA-Thinking
Copy link
Collaborator

@LTA-Thinking LTA-Thinking commented Sep 13, 2024 •
edited by azure-boards bot
Loading

Description

See #4438

Related issues

Addresses AB#124924

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

LTA-Thinking and others added 2 commits September 13, 2024 12:44
@LTA-Thinking
Pagination bug fixes (#4438)
4d83519
@brendankowitz
Disable the ACR admin by default (#4475)
ce2190d 
* Disable the ACR admin by default
* Remove ACR Admin user access
@LTA-Thinking LTA-Thinking requested a review from a team as a code owner September 13, 2024 19:53
@LTA-Thinking LTA-Thinking changed the title Hotfix/pagination fix [Don't Review] Hotfix/pagination fix Sep 13, 2024
@LTA-Thinking LTA-Thinking changed the title [Don't Review] Hotfix/pagination fix Pagination Fix Sep 16, 2024
@LTA-Thinking LTA-Thinking added this to the S150 milestone Sep 16, 2024
@LTA-Thinking LTA-Thinking added Bug Bug bug bug. Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs labels Sep 16, 2024
fhibf
fhibf reviewed Sep 16, 2024
View reviewed changes
samples/templates/default-azuredeploy-docker.json
@@ -720,7 +720,7 @@
"tier": "Basic"
},
"properties": {
"adminUserEnabled": "true"
"adminUserEnabled": "false"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intentional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is already that value in main.

@LTA-Thinking LTA-Thinking merged commit d6793b9 into main Sep 16, 2024
45 of 51 checks passed
@LTA-Thinking LTA-Thinking deleted the hotfix/pagination-fix branch September 16, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhibf fhibf fhibf approved these changes

Assignees
No one assigned
Labels
Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug.
Projects
None yet
Milestone
S150
Development

Successfully merging this pull request may close these issues.
3 participants
@LTA-Thinking @fhibf @brendankowitz